Merged
Conversation
Member
|
Thank you for opening up this PR, looks promising. There were some discussions here on readthedocs vs gh-pages: #856 @noirbizarre any idea why the docs build currently fails? @dklimpel , let's give @noirbizarre a chance to provide feedback. If we don't get any, I can approve and switch to this approach. Personal bias, I'm looking for the easiest thing to support. |
Contributor
Author
|
Thank you for your feedback. I didn't realise that the decision had been made in favour of readthedocs. The reason for the failing CI is:
The setup python job needs for caching a |
aelsabbahy
approved these changes
May 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
Fix docs pipeline.
Build and deploy docs to branchgh_pages. It has do be enabled in https://github.com/goss-org/goss/settings/pages