#799 kgoss: Add GOSS_KUBECTL_RUN_OPTS for kubectl run-specific options#1044
Open
tyrantkhan wants to merge 1 commit intogoss-org:masterfrom
Open
#799 kgoss: Add GOSS_KUBECTL_RUN_OPTS for kubectl run-specific options#1044tyrantkhan wants to merge 1 commit intogoss-org:masterfrom
tyrantkhan wants to merge 1 commit intogoss-org:masterfrom
Conversation
Author
|
@aelsabbahy any chance you could take a look at this?? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #799
Checklist
[X] Documentation is changed or added (if applicable)
Description of change
Adds
GOSS_KUBECTL_RUN_OPTSenvironment variable for options that should only be passed tokubectl run, not to other kubectl commands likewait,cp,exec, ordelete.This is needed because
--overridesis only valid forkubectl run, butGOSS_KUBECTL_OPTSis passed to all kubectl commands, causing errors like:Common use cases:
serviceAccountNamefor imagePullSecrets (private registries)nodeSelectorfor architecture-specific schedulingtolerationsfor tainted nodesExample:
GOSS_KUBECTL_RUN_OPTS='--overrides={"spec":{"serviceAccountName":"my-sa"}}' kgoss run -i myimage:tag📚 Documentation preview 📚: https://goss--1044.org.readthedocs.build/en/1044/