Draft
Conversation
Author
|
@aelsabbahy I completed #871 with the changes required. The integration tests are failing, but I think that's due to the code in the master branch, right? I have the same errors as in this #1013 (actions). |
Author
|
@aelsabbahy When you have a moment, I'd like to hear your thoughts on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make test-all(UNIX) passes. CI will also test thisDescription of change
This PR completes the work done by @berney on #871
This change allows specifying a command to be executed exec style without a shell.
This change is backwards compatible, and existing goss configuration files should continue to work as expected.
This change is needed for operating in environments where a shell doesn't exist, such as testing a distroless docker image.
The syntax is inspired by the Dockerfile
RUN,ENTRYPOINT,CMDinstructions that can take either a string (shell style), or a list (exec style). This allows specifying arguments that contain spaces, etc, as the argument list is explicit.Shell syntax (unchanged from before):
This would be wrapped and executed as
sh -c "figlet test"Exec syntax (this change introduces):
This would be executed directly, without a shell, as
figlet test, wherefigletis arg 0 and test is arg 1.The above could use alternative yaml syntax:
📚 Documentation preview 📚: https://goss--1016.org.readthedocs.build/en/1016/