fix: updated initial position to screen height #657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@aimensasi @aditya-keri-betterhalf could you guys test this pr , thanks 👍 |
|
@gorhom - Works perfectly now. Thanks for the quick fix. When can we expect a newer version with this fix to be released ? |
gorhom
deleted the
fix/642-updated-initial-position-to-screen-height
branch
Owner
Author
|
thanks @aditya-keri-betterhalf for testing, it should be released soon |
|
Thanks a lot, I just installed the latest release and the issue is resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #642
Motivation
Android with translucent status bar causes the window height to be smaller than the screen height, which led the sheet to be visible when it is closed.
Installation