fix: use correct TS types for style prop #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonovak
changed the title
Owner
|
thanks @vonovak for spotting it, the dev screen used for experimenting new features and i did not fix it when updating footer component 🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The motivation is to be able to pass styles to the bottom sheet components the same way as with other react native components, see eg. https://github.com/DefinitelyTyped/DefinitelyTyped/blob/ff070e46d5821d3a28beed3707386677231ce204/types/react-native/index.d.ts#L2919
current situation:
The second screenshot contains valid styles, but the TS typings currently do not accept them. This change makes it so that the second example is valid too.
also removed
appearanceBehaviorbecause it does not appear to be used anywhere. Actually,animatedFooterPositionshould be passed in that place - it'd be good to include some static checks in the repo's pipeline it seems 🙂