Skip to content

fix(bottom-sheet-modal): behind native modal view #1309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2023
Merged

fix(bottom-sheet-modal): behind native modal view #1309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0df7f5a
fix: bottom sheet modal appear behind native views
magrinj Mar 2, 2023
fa3fd44
feat: add bottomSheetWrapper prop to specify a custom wrapper component
magrinj Jun 5, 2023
d55a121
fix: edit regardless of the comments
magrinj Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 20 additions & 17 deletions src/components/bottomSheetModal/BottomSheetModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ const BottomSheetModalComponent = forwardRef<
snapPoints,
enablePanDownToClose = true,
animateOnMount = true,
containerComponent: ContainerComponent = React.Fragment,

// callbacks
onChange: _providedOnChange,
Expand Down Expand Up @@ -375,23 +376,25 @@ const BottomSheetModalComponent = forwardRef<
handleOnUpdate={handlePortalRender}
handleOnUnmount={handlePortalOnUnmount}
>
<BottomSheet
{...bottomSheetProps}
ref={bottomSheetRef}
key={key}
index={index}
snapPoints={snapPoints}
enablePanDownToClose={enablePanDownToClose}
animateOnMount={animateOnMount}
containerHeight={containerHeight}
containerOffset={containerOffset}
onChange={handleBottomSheetOnChange}
onClose={handleBottomSheetOnClose}
children={
typeof Content === 'function' ? <Content data={data} /> : Content
}
$modal={true}
/>
<ContainerComponent>
<BottomSheet
{...bottomSheetProps}
ref={bottomSheetRef}
key={key}
index={index}
snapPoints={snapPoints}
enablePanDownToClose={enablePanDownToClose}
animateOnMount={animateOnMount}
containerHeight={containerHeight}
containerOffset={containerOffset}
onChange={handleBottomSheetOnChange}
onClose={handleBottomSheetOnClose}
children={
typeof Content === 'function' ? <Content data={data} /> : Content
}
$modal={true}
/>
</ContainerComponent>
</Portal>
) : null;
});
Expand Down
8 changes: 8 additions & 0 deletions src/components/bottomSheetModal/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@ export interface BottomSheetModalProps
*/
enableDismissOnClose?: boolean;

/**
* Add a custom container like FullWindowOverlay
* allow to fix issue like https://github.com/gorhom/react-native-bottom-sheet/issues/832
* @type React.ComponentType
* @default undefined
*/
containerComponent?: React.ComponentType<React.PropsWithChildren<{}>>;

// callbacks
/**
* Callback when the modal dismissed.
Expand Down