Skip to content

dql: xgo; encoding: xgo; encoding.Object#2627

Merged
xushiwei merged 3 commits intogoplus:mainfrom
xushiwei:q
Feb 15, 2026
Merged

dql: xgo; encoding: xgo; encoding.Object#2627
xushiwei merged 3 commits intogoplus:mainfrom
xushiwei:q

Conversation

@xushiwei
Copy link
Member

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @xushiwei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the XGo ecosystem by introducing a dedicated Domain Query Language (DQL) for XGo Abstract Syntax Trees, enabling more flexible and powerful code analysis and manipulation. Concurrently, it refines the encoding packages by standardizing the primary data type returned by their New functions, promoting a more uniform and predictable API across different data formats.

Highlights

  • New DQL for XGo AST: Introduced a new dql/xgo package that provides a powerful Domain Query Language (DQL) for querying and manipulating XGo Abstract Syntax Trees (ASTs). This includes Node and NodeSet types, along with methods for traversing, selecting, and extracting information from AST nodes.
  • Standardized encoding.Object Type: Standardized the return type of New functions across various encoding packages (csv, golang, html, json, regexp, regexposix, xml, yaml) by introducing a consistent Object type alias. This improves consistency and clarity when working with encoded data.
  • New encoding/xgo Package: Added a new encoding/xgo package, mirroring the encoding pattern, to provide a New function that parses XGo source code into an xgo.File object, leveraging the new dql/xgo parsing capabilities.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • demo/dql-xgo/xgoq.xgo
    • Added a new demo file demonstrating XGo AST querying capabilities.
  • dql/xgo/parse.go
    • Added File struct for XGo AST representation.
    • Added ParseFile function to parse XGo source code.
    • Implemented XGo_Elem, XGo_Child, and XGo_Any methods for File to enable AST traversal.
  • dql/xgo/xgo.go
    • Added Node and NodeSet types for XGo AST querying.
    • Implemented various constructors for NodeSet (e.g., NodeSet_Cast, Root, Nodes, New, From, Source).
    • Provided comprehensive query methods for NodeSet including XGo_Enum, XGo_Select, XGo_Elem, XGo_Child, XGo_Any, All, One, Single.
    • Added attribute access methods XGo_Attr__0, XGo_Attr__1, and Class for NodeSet.
  • encoding/csv/csv.go
    • Introduced Object type alias for [][]string.
    • Updated New function to return Object.
  • encoding/golang/golang.go
    • Introduced Object type alias for golang.File.
    • Updated New function to return *Object.
  • encoding/html/html.go
    • Introduced Object type alias for html.File.
    • Updated New function to return *Object.
  • encoding/json/json.go
    • Introduced Object type alias for any.
    • Updated New function to return Object.
  • encoding/regexp/regexp.go
    • Introduced Object type alias for regexp.Regexp.
    • Updated New function to return *Object.
  • encoding/regexposix/regexp.go
    • Introduced Object type alias for regexp.Regexp.
    • Updated New function to return *Object.
  • encoding/xgo/xgo.go
    • Added Object type alias for xgo.File.
    • Added New function to parse XGo source code into an xgo.File object.
  • encoding/xml/xml.go
    • Introduced Object type alias for xml.Node.
    • Updated New function to return *Object.
  • encoding/yaml/yaml.go
    • Introduced Object type alias for any.
    • Updated New function to return Object.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces DQL support for the XGo language by adding new packages dql/xgo and encoding/xgo. It also refactors several encoding packages to use a consistent Object type alias, improving code uniformity. The implementation for XGo DQL follows the existing patterns for other languages like Go, and a helpful demo file is included. The changes are well-structured and clear. I have one minor suggestion to fix a typo in a panic message.

@codecov
Copy link

codecov bot commented Feb 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.10%. Comparing base (0e574f7) to head (77d62f2).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2627   +/-   ##
=======================================
  Coverage   94.10%   94.10%           
=======================================
  Files          32       32           
  Lines        9949     9949           
=======================================
  Hits         9363     9363           
  Misses        418      418           
  Partials      168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xushiwei xushiwei merged commit 69debd9 into goplus:main Feb 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant