dql: all - cache operation

[xushiwei]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @xushiwei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the DQL library by introducing a caching mechanism for NodeSet traversals, aiming to boost performance for operations that iterate over nodes multiple times. It also streamlines the creation of NodeSet objects with a new helper function and refines data extraction logic in the GitHub repository list fetcher.

Highlights

• Performance Optimization: Introduced an All() method (or XGo_all() for specific packages) to the NodeSet type across html, maps, reflects, and xml packages. This method serves as a cache operation to optimize performance when nodes need to be traversed multiple times.
• NodeSet Creation Helper: Added a new Nodes() helper function in the html, maps, reflects, and xml packages. This function allows for the creation of a NodeSet from a variadic list of existing nodes, simplifying NodeSet construction.
• Simplified Data Extraction: Removed explicit empty string defaults (?:"") from several data extraction fields in repoList.xgo, indicating a potential refinement in how nil or empty values are handled by the DQL engine or an assumption that these fields will always have values.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• dql/fetcher/github.com/repoList/repoList.xgo
  • Removed default empty string assignments for forkedFrom, title, language, updateTime, and next fields.
• dql/html/html.go
  • Added a Nodes function to create a NodeSet from a slice of *Node.
  • Implemented an All method on NodeSet to collect and cache all nodes for repeated traversals.
• dql/maps/maps.go
  • Added a Nodes function to create a NodeSet from a slice of Node.
  • Implemented an XGo_all method on NodeSet to collect and cache all nodes for repeated traversals.
• dql/reflects/reflects.go
  • Added a Nodes function to create a NodeSet from a slice of Node.
  • Implemented an XGo_all method on NodeSet to collect and cache all nodes for repeated traversals.
• dql/xml/xml.go
  • Added a Nodes function to create a NodeSet from a slice of *Node.
  • Implemented an XGo_all method on NodeSet to collect and cache all nodes for repeated traversals.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.02%. Comparing base (838cfe1) to head (9c5e615).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2614   +/-   ##
=======================================
  Coverage   94.02%   94.02%           
=======================================
  Files          32       32           
  Lines        9891     9891           
=======================================
  Hits         9300     9300           
  Misses        422      422           
  Partials      169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Code Review

This pull request introduces a useful all() caching operation to the DQL packages and cleans up some redundant code, aiming to improve performance and code clarity. However, a security audit identified two medium-severity Denial of Service (DoS) vulnerabilities in dql/fetcher/github.com/repoList/repoList.xgo. The removal of nil-coalescing operators (?:) can cause the application to panic and crash if it parses HTML content that is missing expected elements, which an attacker could exploit. Additionally, there are a few minor suggestions to enhance consistency.