Skip to content

doc/builtin: XGo style#2602

Merged
xushiwei merged 1 commit intogoplus:mainfrom
xushiwei:q
Feb 6, 2026
Merged

doc/builtin: XGo style#2602
xushiwei merged 1 commit intogoplus:mainfrom
xushiwei:q

Conversation

@xushiwei
Copy link
Member

@xushiwei xushiwei commented Feb 6, 2026

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @xushiwei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the doc/builtin.md file to align code examples with the XGo style guidelines by removing parentheses and updating naming conventions. It also removes some documentation sections, possibly to improve conciseness or reorganize content.

Highlights

  • Code Style: The code examples in doc/builtin.md have been updated to adhere to the XGo style, specifically changing file.Close() to file.close and t.Name() to t.name.
  • Documentation Cleanup: Removed the section on omitting parentheses in XGo, as well as the sections on error handling and Unicode support, likely to streamline the documentation or move these topics elsewhere.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • doc/builtin.md
    • Updated code examples to use XGo style (e.g., file.close instead of file.Close()).
    • Modified reflection examples to use t.name instead of t.Name().
    • Removed sections on omitting parentheses, error handling, and Unicode support.
Activity
  • The pull request modifies the documentation file doc/builtin.md to adhere to XGo style guidelines.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@xgopilot
Copy link

xgopilot bot commented Feb 6, 2026

Review Summary

This PR appropriately updates documentation style to align with XGo conventions. The style changes (file.close, t.name) are consistent with other examples throughout the document.

The removed sections ("Omitting Parentheses", "Error Handling", "Unicode Support") are justified as this content is more comprehensively covered in doc/fncall.md and doc/string.md.

LGTM ✓

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the doc/builtin.md file to align with the XGo language style, primarily by changing method calls like file.Close() to property-style access like file.close in code examples. It also removes several sections to reduce redundancy with other documentation files. While the refactoring is generally good, I've noted that the removal of the "Omitting Parentheses" section may result in the loss of important information for developers learning XGo, as it explicitly described a key syntactic feature.

I am having trouble creating individual review comments. Click here to see my feedback.

doc/builtin.md (955-964)

medium

This change removes the "Omitting Parentheses" section, which provides a clear explanation of a key XGo language feature (omitting parentheses for no-argument function/method calls). While other parts of the documentation use this syntax in examples, removing the explicit explanation might make it harder for new users to understand the language's syntax rules. Please consider restoring this section or moving its content to a more appropriate location (e.g., a dedicated syntax guide or the language specification) to ensure this important information is not lost.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.96%. Comparing base (3c4110b) to head (2356f20).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2602   +/-   ##
=======================================
  Coverage   93.96%   93.96%           
=======================================
  Files          34       34           
  Lines        9808     9808           
=======================================
  Hits         9216     9216           
  Misses        422      422           
  Partials      170      170           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xushiwei xushiwei merged commit 0355fc9 into goplus:main Feb 6, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant