fix(Dockerfile): extract artifacts from tarball when using GoReleaser#2032
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2032 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 42 42
Lines 11734 11734
=======================================
Hits 10953 10953
Misses 624 624
Partials 157 157 ☔ View full report in Codecov by Sentry. |
According to GoReleaser docs, the directory names inside dist have no guarantee of remaining the same across different GoReleaser versions[^1]. Therefore, we extract from tarballs instead of using those directories directly. [^1]: https://goreleaser.com/customization/builds/#a-note-about-directory-names-inside-dist Signed-off-by: Aofei Sheng <aofei@aofeisheng.com>
aofei
changed the title
Member
Author
|
/cc @cpunion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to GoReleaser docs, the directory names inside dist have no guarantee of remaining the same across different GoReleaser versions1. Therefore, we extract from tarballs instead of using those directories directly.
Footnotes
https://goreleaser.com/customization/builds/#a-note-about-directory-names-inside-dist ↩