Skip to content

ServeAndDial: shutdown gop command when client.Close#1525

Merged
xushiwei merged 2 commits into
goplus:mainfrom
xushiwei:rpc
Nov 7, 2023
Merged

ServeAndDial: shutdown gop command when client.Close#1525
xushiwei merged 2 commits into
goplus:mainfrom
xushiwei:rpc

Conversation

@xushiwei
Copy link
Copy Markdown
Member

@xushiwei xushiwei commented Nov 7, 2023

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be2ce1e) 91.19% compared to head (cf773b5) 91.19%.
Report is 7 commits behind head on main.

❗ Current head cf773b5 differs from pull request most recent head d095139. Consider uploading reports for the commit d095139 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1525   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files          33       33           
  Lines        9740     9740           
=======================================
  Hits         8882     8882           
  Misses        693      693           
  Partials      165      165           
Files Coverage Δ
x/jsonrpc2/stdio/client.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xushiwei xushiwei merged commit ddd2e33 into goplus:main Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant