Skip to content

build: add command tracing and entry module name#1584

Merged
xushiwei merged 2 commits intogoplus:mainfrom
cpunion:pr/build-trace
Jan 26, 2026
Merged

build: add command tracing and entry module name#1584
xushiwei merged 2 commits intogoplus:mainfrom
cpunion:pr/build-trace

Conversation

@cpunion
Copy link
Collaborator

@cpunion cpunion commented Jan 24, 2026

Summary

  • Add -x flag to print build commands for tracing, separate from -v.
  • Keep entry module name as entry_main to avoid confusing it with a real main package in logs/traces.

Details

  • -x prints the exact commands executed during compile/link/run, and can be combined with -v.
  • Command tracing also covers relevant Cgo clang invocations.

Testing

  • Not run (PR description only)

@gemini-code-assist
Copy link

Summary of Changes

Hello @cpunion, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the build system's observability by introducing a dedicated command tracing mechanism via the -x flag. This allows users to see the exact commands being executed at various stages of compilation, linking, and execution. Additionally, it refines the internal naming convention for the main entry module during linking, contributing to overall system consistency and improved debugging capabilities.

Highlights

  • Command Tracing Flag: Introduced a new command-line flag, -x, to enable detailed tracing of commands executed during the build, compile, link, and run phases. This provides greater visibility into the build process.
  • Refactored Flag Handling: The -x flag was refactored from a combined flag with -n in cmd/internal/base/pass.go to its own explicit definition in cmd/internal/flags/flags.go, improving clarity and control.
  • Entry Module Naming: Standardized the name of the main entry module during the linking process to a fixed string "entry_main" instead of using a dynamic package path.
  • Integrated Verbosity: The new command tracing functionality is integrated with existing verbose logging, allowing either the -x flag or the verbose flag to trigger command output for various operations.
  • Cgo Command Tracing: Extended command tracing to include clang invocations related to Cgo processing, specifically for extracting macro and function names, enhancing debugging for Cgo interactions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@xgopilot
Copy link
Contributor

xgopilot bot commented Jan 24, 2026

Code Review Summary

This PR successfully adds command tracing (-x flag) separate from verbose mode, improving debugging capabilities. The implementation is largely sound with good separation of concerns.

Key improvements:
✅ Clean separation of -x (print commands) from -v (verbose output)
✅ Consistent command printing across compilation, linking, and runtime phases
✅ Better tracing context with package names in output

Issues identified:
⚠️ Inconsistent verbose parameter handling in buildPkg (see inline comment)
💡 Entry module name change needs documentation
💡 Consider helper method for shouldPrintCommands pattern

Testing recommendation: Add tests verifying -x behavior independently and combined with -v.

Overall, this is a valuable addition that will help users understand build processes. The inline comments highlight areas for refinement.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces command tracing via a new -x flag and refines the entry module naming for better logging. The changes are well-implemented and consistently applied across the build system. The new flag enhances debuggability by allowing users to see the exact commands being executed. I have a couple of minor suggestions to improve code readability and maintainability.

@codecov
Copy link

codecov bot commented Jan 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.01%. Comparing base (298669b) to head (ed21fe3).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1584   +/-   ##
=======================================
  Coverage   91.01%   91.01%           
=======================================
  Files          45       45           
  Lines       11971    11971           
=======================================
  Hits        10896    10896           
  Misses        899      899           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xushiwei xushiwei merged commit ebf66ae into goplus:main Jan 26, 2026
45 checks passed
@cpunion cpunion deleted the pr/build-trace branch March 6, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants