runtime: align pointer print formatting

[luoliwoshang]

Fixed #1557

Summary

• On Linux, using %p directly formats nil as "nil"; to align with Go, always emit "0x" prefix plus hex digits so nil becomes 0x0.

Validation

• Confirmed in test(cl): add run result output verification #1545 outputs:
  • TestRunFromTestgo / invoke
  • TestRunFromTestgo / reader
  • TestRunFromTestgo / struczero
  • TestRunFromTestrt / tpmethod

[gemini-code-assist]

Summary of Changes

Hello @luoliwoshang, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the runtime's internal pointer printing diverged from the standard Go formatting. The changes ensure that all pointer outputs, including those for nil values, are consistently prefixed with "0x", thereby improving uniformity across the system's logging and debugging outputs.

Highlights

• Pointer Formatting Alignment: The PrintPointer function in runtime/internal/runtime/z_print.go has been modified to ensure its output consistently matches Go's builtin print/println pointer formatting, specifically by always including the "0x" prefix, even for nil pointers.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to align pointer printing with Go's standard 0x... format. However, the implementation introduces a potential race condition by making two separate, non-atomic calls to c.Fprintf. This can lead to corrupted output in concurrent applications. Additionally, it incorrectly uses a format specifier for uint64 with a uintptr type, which will cause undefined behavior on 32-bit systems. My review includes a suggestion to consolidate the printing into a single, atomic Fprintf call using a new, type-correct format string for uintptr.

[xgopilot]

Code Review Summary

Overall: LGTM ✅ - This is a well-motivated fix that correctly addresses the pointer formatting compatibility issue between LLGo and Go.

Key Findings:

• Correctness: The implementation correctly matches Go's behavior (0x prefix for all pointers including nil)
• Security: No vulnerabilities introduced; format string safety is maintained
• Quality: Clean, straightforward implementation with clear intent

Minor Suggestions:

Two optional enhancements noted in inline comments for performance and documentation. Both are low-priority improvements to an already solid fix.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.01%. Comparing base (01ee853) to head (cc37bfc).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1558   +/-   ##
=======================================
  Coverage   91.01%   91.01%           
=======================================
  Files          45       45           
  Lines       11958    11958           
=======================================
  Hits        10883    10883           
  Misses        899      899           
  Partials      176      176           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.