Skip to content

chore: remove duplicate paths in getNewlibESP32ConfigRISCV#1541

Merged
xushiwei merged 1 commit intomainfrom
xgopilot/issue-1540-1767876330
Jan 8, 2026
Merged

chore: remove duplicate paths in getNewlibESP32ConfigRISCV#1541
xushiwei merged 1 commit intomainfrom
xgopilot/issue-1540-1767876330

Conversation

@xgopilot
Copy link
Contributor

@xgopilot xgopilot bot commented Jan 8, 2026

Requested by @luoliwoshang

This PR fixes issue #1540 by removing duplicate file paths in the getNewlibESP32ConfigRISCV function.

Summary

  • Removed 44 duplicate file paths from the second CompileGroup in getNewlibESP32ConfigRISCV function
  • The duplicate paths (lines 262-305) were exact copies of lines 229-261
  • Tests pass successfully after the cleanup

Changes

  • Modified: internal/crosscompile/compile/libc/newlibesp.go

Fixes #1540

Removed 44 duplicate file paths from the second CompileGroup in
getNewlibESP32ConfigRISCV function. The paths from lines 262-305
were exact duplicates of lines 229-261.

Fixes #1540

Generated with [codeagent](https://github.com/qbox/codeagent)
Co-authored-by: luoliwoshang <51194195+luoliwoshang@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.00%. Comparing base (a3db8d0) to head (7a69f78).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1541      +/-   ##
==========================================
- Coverage   91.04%   91.00%   -0.04%     
==========================================
  Files          45       45              
  Lines       11999    11955      -44     
==========================================
- Hits        10924    10880      -44     
  Misses        899      899              
  Partials      176      176              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xushiwei xushiwei merged commit 34b872c into main Jan 8, 2026
45 checks passed
@xgopilot xgopilot bot deleted the xgopilot/issue-1540-1767876330 branch January 8, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore:remove some dupilicate path at getNewlibESP32ConfigRISCV

2 participants