fix: ensure dev/llgo.sh always rebuilds with -tags=dev#1519
Merged
Conversation
This fixes issue #1518 where dev/llgo.sh would skip rebuilding with the dev tag when the llgo binary already exists. Now dev/_llgo_setup.sh uses 'go install -tags=dev ./cmd/llgo' instead of 'go install ./cmd/llgo' to ensure the dev build is always used. Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: cpunion <[email protected]>
Remove conditional checks in _llgo_ensure_llgo_cli and always run 'go install -tags=dev ./cmd/llgo' on every invocation. This ensures the dev build is always used regardless of whether the binary exists or files have changed. Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: cpunion <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1519 +/- ##
==========================================
- Coverage 91.07% 91.03% -0.04%
==========================================
Files 45 45
Lines 11996 11996
==========================================
- Hits 10925 10921 -4
- Misses 895 899 +4
Partials 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by @cpunion
Fixes #1518
Summary
This PR ensures that
dev/llgo.shalways rebuilds thellgoCLI with the-tags=devflag, addressing the issue where the wrapper would reuse an existing binary built without the dev tag.Changes
dev/_llgo_setup.sh:53to usego install -tags=dev ./cmd/llgoinstead ofgo install ./cmd/llgoImpact
Every invocation of
dev/llgo.shwill now properly use the dev build of llgo, regardless of whether a binary already exists at$GOBIN/llgo.