Skip to content

Record compiler hash in build fingerprints#1516

Merged
xushiwei merged 4 commits intogoplus:mainfrom
cpunion:feature/compiler-hash-metadata
Jan 2, 2026
Merged

Record compiler hash in build fingerprints#1516
xushiwei merged 4 commits intogoplus:mainfrom
cpunion:feature/compiler-hash-metadata

Conversation

@cpunion
Copy link
Collaborator

@cpunion cpunion commented Dec 30, 2025

Summary

  • compute a deterministic hash for development compiler builds based on binary metadata
  • add LLGO compiler hash into the manifest env so cache entries invalidate when the compiler changes

Testing

  • go test ./...

@gemini-code-assist
Copy link

Summary of Changes

Hello @cpunion, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the build system by incorporating a unique hash of the llgo compiler into the build fingerprints. This change ensures that development builds can reliably detect when the compiler itself has been updated, leading to automatic cache invalidation and preventing the use of stale cached artifacts. The primary goal is to improve build consistency and reliability by tying cached outputs directly to the specific compiler version used.

Highlights

  • Compiler Hash Integration: Introduced a mechanism to compute and record a deterministic hash for the llgo compiler in build fingerprints.
  • Cache Invalidation: The LLGO_COMPILER_HASH is now added to the manifest environment, ensuring that build cache entries are automatically invalidated when the compiler binary changes.
  • Deterministic Hashing: For development builds, the compiler hash is derived from the executable's metadata (modification time and file size), providing a consistent way to detect compiler changes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a mechanism to generate a hash for development compiler builds, which is used to invalidate cache entries when the compiler is updated. The implementation is sound and primarily involves hashing the compiler executable's metadata (modification time and size). The changes are well-contained within the build fingerprinting and environment versioning logic. I have a couple of suggestions to enhance maintainability and error reporting in internal/env/version.go.

@xgopilot
Copy link
Contributor

xgopilot bot commented Dec 30, 2025

Code Review Summary

Overall Assessment: Well-implemented feature with minor improvements needed

This PR successfully adds compiler hash tracking to build fingerprints for proper cache invalidation during development. The implementation is clean, secure, and performant.

Key Strengths

  • Performance: Negligible overhead with smart caching and early exit for release builds
  • Security: No vulnerabilities; uses SHA-256 and system-controlled paths
  • Integration: Cleanly integrates into existing manifest/fingerprint system

Required Improvements

  1. Missing unit tests for hashMetadata() and compilerHashFromPath() - CLAUDE.md requires tests for all features
  2. Incomplete documentation for internal functions and initialization logic

Recommendations

  • Add unit tests covering normal cases, edge cases (size=0), and error conditions
  • Document the internal functions to clarify metadata hashing vs content hashing
  • Improve error message consistency in the init function

See inline comments for specific suggestions.

@cpunion cpunion force-pushed the feature/compiler-hash-metadata branch from 4784478 to d346bec Compare December 30, 2025 02:20
@codecov
Copy link

codecov bot commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.03%. Comparing base (c844c73) to head (046c0d9).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1516      +/-   ##
==========================================
+ Coverage   90.78%   91.03%   +0.25%     
==========================================
  Files          45       45              
  Lines       11970    11996      +26     
==========================================
+ Hits        10867    10921      +54     
+ Misses        929      899      -30     
- Partials      174      176       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cpunion cpunion force-pushed the feature/compiler-hash-metadata branch from 3745f26 to 046c0d9 Compare January 2, 2026 04:28
@xushiwei xushiwei merged commit ef4877e into goplus:main Jan 2, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants