Skip to content

reflect: fix Type.Name() returning empty string for basic types #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xushiwei merged 2 commits into from
Dec 29, 2025
Merged

reflect: fix Type.Name() returning empty string for basic types #1511

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a362ba0
reflect: fix Type.Name() returning empty string for basic types
luoliwoshang Dec 29, 2025
f84928d
test: add regression test for issue #1412
luoliwoshang Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions runtime/internal/lib/reflect/type.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,11 @@ func pkgPathFor(t *abi.Type) string {

func (t *rtype) Name() string {
if !t.t.HasName() {
// For basic types (int, string, etc.), String() returns the type name directly.
// Basic types don't have TFlagNamed set, but they do have names.
if t.t.Kind() <= abi.UnsafePointer {
Copy link
Contributor

@xgopilot xgopilot bot Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation: Clarify basic type boundary

The comment mentions "basic types" but doesn't explain why <= abi.UnsafePointer is the boundary. Consider enhancing the comment to explain that this covers all predefined types (Invalid through UnsafePointer = kinds 0-25), while composite types (Array, Chan, Func, etc.) correctly return empty string when unnamed.

Suggested addition:

// For basic types (int, string, etc.), String() returns the type name directly.
// Basic types don't have TFlagNamed set, but they do have names.
// Check if Kind <= abi.UnsafePointer (25), which covers all basic predefined types
// from Invalid(0) through UnsafePointer(25). Types beyond this are composite types.

return t.String()
}
return ""
}
s := t.String()
Expand Down
Loading