fix(esp32c3): use newlib startup and merge init_array to rodata for println support #1435
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| #!/bin/bash | ||
|
|
||
| # ESP32-C3 Startup Regression Test | ||
| # Verify that _start uses newlib's __libc_init_array (not TinyGo's start.S) | ||
|
|
||
| set -e | ||
|
|
||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
| TEMP_DIR=$(mktemp -d) | ||
| TEST_GO="$TEMP_DIR/main.go" | ||
| TEST_ELF="$TEMP_DIR/test.elf" | ||
|
|
||
| cleanup() { | ||
| rm -rf "$TEMP_DIR" | ||
| } | ||
| trap cleanup EXIT | ||
|
|
||
| echo "==> Creating minimal test program..." | ||
| cat > "$TEST_GO" << 'EOF' | ||
| package main | ||
|
|
||
| func main() {} | ||
| EOF | ||
|
|
||
| echo "==> Building for ESP32-C3 target..." | ||
| cd "$TEMP_DIR" | ||
| llgo build -target=esp32c3 -o "$TEST_ELF" "$TEST_GO" | ||
|
|
||
| if [ ! -f "$TEST_ELF" ]; then | ||
| echo "✗ FAIL: Build failed, $TEST_ELF not found" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "==> Checking for __libc_init_array call in _start..." | ||
|
|
||
| # Disassemble _start and check for __libc_init_array call | ||
| if llvm-objdump -d "$TEST_ELF" | grep -A30 "<_start>:" | grep "__libc_init_array" > /dev/null; then | ||
| echo "✓ PASS: _start calls __libc_init_array" | ||
| echo " This confirms ESP32-C3 uses newlib's standard startup" | ||
| echo " (crt0-riscv32-unknown-none, not TinyGo's start.S)" | ||
| exit 0 | ||
| else | ||
| echo "✗ FAIL: _start does NOT call __libc_init_array" | ||
| echo " ESP32-C3 should use newlib's startup flow" | ||
| echo " Check targets/esp32c3.json inheritance chain" | ||
| echo "" | ||
| echo "Expected: esp32c3 → riscv32-llgo → riscv-llgo → riscv-basic" | ||
| echo "Current _start disassembly:" | ||
| llvm-objdump -d "$TEST_ELF" | grep -A30 "<_start>:" || true | ||
| exit 1 | ||
| fi | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "goos": "linux", | ||
| "goarch": "arm", | ||
| "build-tags": ["tinygo.riscv", "baremetal", "linux", "arm"], | ||
luoliwoshang marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "gc": "conservative", | ||
| "linker": "ld.lld", | ||
| "rtlib": "compiler-rt", | ||
| "libc": "picolibc", | ||
| "cflags": [ | ||
| "-Werror", | ||
| "-mno-relax", | ||
| "-fno-exceptions", "-fno-unwind-tables", "-fno-asynchronous-unwind-tables", | ||
| "-ffunction-sections", "-fdata-sections" | ||
| ], | ||
| "ldflags": [ | ||
| "--gc-sections" | ||
| ], | ||
| "gdb": ["riscv64-unknown-elf-gdb"] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "inherits": ["riscv-basic"], | ||
| "build-tags": ["target_llgo"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| { | ||
| "inherits": ["riscv-llgo"], | ||
| "llvm-target": "riscv32-unknown-none", | ||
| "cpu": "generic-rv32", | ||
| "target-abi": "ilp32", | ||
| "build-tags": ["tinygo.riscv32"], | ||
| "scheduler": "tasks", | ||
| "default-stack-size": 2048, | ||
| "cflags": [ | ||
| "-march=rv32imac" | ||
| ], | ||
| "ldflags": [ | ||
| "-melf32lriscv" | ||
| ], | ||
| "gdb": [ | ||
| "gdb-multiarch", | ||
| "gdb" | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider increasing
-A30to-A50for additional safety margin. While 30 lines is reasonable for most_startimplementations, using a larger value provides extra headroom if the function grows in the future.