Skip to content

xtool/safesplit:properly handle consecutive short flags#1243

Merged
xushiwei merged 1 commit intogoplus:mainfrom
luoliwoshang:llgo/safesplit
Aug 28, 2025
Merged

xtool/safesplit:properly handle consecutive short flags#1243
xushiwei merged 1 commit intogoplus:mainfrom
luoliwoshang:llgo/safesplit

Conversation

@luoliwoshang
Copy link
Member

@luoliwoshang luoliwoshang commented Aug 27, 2025

fix #1244

at the homebrew test case will set the CFLAGS

==> CFLAGS: -Os -w -pipe  -mmacosx-version-min=15 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk
/opt/homebrew/Cellar/llgo/0.12.12/libexec/crosscompile/clang/bin/clang++ -Os -w-pipe -mmacosx-version-min=15 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk -Qunused-arguments -Wno-unused-command-line-argument --sysroot=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.5.sdk -I/opt/homebrew/Cellar/llgo/0.12.12/libexec/crosscompile/clang/include -o /Users/zhangzhiyang/Library/Caches/Homebrew/go_cache/9f/9ff6c578d2686798b95abb59ea500cd2091450c2073cd84e1ab7d4bacfedafb0-d.o -c /private/tmp/llgo-2984895133.ll -Wno-override-module

clang++: error: unknown argument '-w-pipe'; did you mean '--pipe'?
panic: export object of internal/goarch failed: exit status 1

the -w-pipe is from -w and -pipe, current process combine them to -w-pipe is not expected

@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.80%. Comparing base (cf2d1ef) to head (0935d10).
⚠️ Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1243   +/-   ##
=======================================
  Coverage   87.80%   87.80%           
=======================================
  Files          35       35           
  Lines        8941     8941           
=======================================
  Hits         7851     7851           
  Misses        979      979           
  Partials      111      111           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xushiwei xushiwei merged commit 2160710 into goplus:main Aug 28, 2025
34 checks passed
luoliwoshang added a commit to luoliwoshang/homebrew-core that referenced this pull request Aug 29, 2025
llvm build cache

with mac cgo config

with c++17

-Wl,-rpath with llvm

remove CFLAG unset by goplus/llgo#1243 merged

with llgo embed target build test

DRUNTIMES_CMAKE_ARGS set RPATH

clang prefix

linux rpath

-DLLVM_ENABLE_LIBEDIT=OFF
luoliwoshang added a commit to luoliwoshang/homebrew-core that referenced this pull request Sep 1, 2025
llvm build cache

with mac cgo config

with c++17

-Wl,-rpath with llvm

remove CFLAG unset by goplus/llgo#1243 merged

with llgo embed target build test

DRUNTIMES_CMAKE_ARGS set RPATH

clang prefix

linux rpath

-DLLVM_ENABLE_LIBEDIT=OFF

refine rb struct

llvm test off

remove some llvm component as tinygo

build only nessary executable

-DLLVM_INSTALL_UTILS=OFF
luoliwoshang added a commit to luoliwoshang/homebrew-core that referenced this pull request Sep 1, 2025
llvm build cache

with mac cgo config

with c++17

-Wl,-rpath with llvm

remove CFLAG unset by goplus/llgo#1243 merged

with llgo embed target build test

DRUNTIMES_CMAKE_ARGS set RPATH

clang prefix

linux rpath

-DLLVM_ENABLE_LIBEDIT=OFF

refine rb struct

llvm test off

same rpath use

reduce llvm pack same with goplus/espressif-llvm-project-prebuilt#13

remove unuse component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: unexpect cflag combine cause compile fail

3 participants