Skip to content

ci/doc:install libunwind-19 & libc++-19#1149

Merged
xushiwei merged 2 commits intogoplus:mainfrom
luoliwoshang:readme/dep
Jun 22, 2025
Merged

ci/doc:install libunwind-19 & libc++-19#1149
xushiwei merged 2 commits intogoplus:mainfrom
luoliwoshang:readme/dep

Conversation

@luoliwoshang
Copy link
Member

@luoliwoshang luoliwoshang commented Jun 12, 2025

with clang++ #1147

test with Homebrew/homebrew-core#227010

  • use llvm/libunwind to instead libunwind because the llvm/libc++ is conflict with independant libunwind
  • add "-L#{llvm.opt_lib} to support link -lc++

@codecov
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.62%. Comparing base (e68355d) to head (65f1c25).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1149   +/-   ##
=======================================
  Coverage   86.62%   86.62%           
=======================================
  Files          29       29           
  Lines        7344     7344           
=======================================
  Hits         6362     6362           
  Misses        915      915           
  Partials       67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@luoliwoshang luoliwoshang force-pushed the readme/dep branch 3 times, most recently from 3a31659 to 45ca23e Compare June 16, 2025 07:23
@cpunion
Copy link
Collaborator

cpunion commented Jun 16, 2025

This change need test homebrew compatible:

  1. Create a release on your cloned repo (stable version).
  2. Create a PR to test this release on homebrew-core's LLGo formula.

@luoliwoshang
Copy link
Member Author

luoliwoshang commented Jun 16, 2025

This change need test homebrew compatible:

got it ,i will test it ,is it for homebrew-linux?

@cpunion
Copy link
Collaborator

cpunion commented Jun 16, 2025

This change need test homebrew compatible:

got it ,i will test it ,is it for homebrew-linux?

Creating a PR on homebrew-core triggers tests on both macOS and Linux. Testing only on your local machine is insufficient, as some cases might be broken on Homebrew's pre-built bottles, only a homebrew-core PR can cover these pre-built tests.

@luoliwoshang
Copy link
Member Author

This change need test homebrew compatible:

got it ,i will test it ,is it for homebrew-linux?

Creating a PR on homebrew-core triggers tests on both macOS and Linux. Testing only on your local machine is insufficient, as some cases might be broken on Homebrew's pre-built bottles, only a homebrew-core PR can cover these pre-built tests.

Additionally, for Homebrew's llvm@19 on Linux, it seems to automatically include libunwind and libc++, so they don't need to be installed separately like with apt. That is why I did not add them as extra installations in the formula.

@cpunion
Copy link
Collaborator

cpunion commented Jun 16, 2025

It seems that on Linux, Homebrew's llvm@19 package automatically includes libunwind and libc++, unlike apt where they need to be installed separately.

Need fix tap syntax to pass the [CI / conclusion (pull_request)] step to test pre-built bottles, some errors happened before.

@luoliwoshang
Copy link
Member Author

@luoliwoshang luoliwoshang marked this pull request as draft June 20, 2025 08:19
@luoliwoshang
Copy link
Member Author

Homebrew/homebrew-core#227010 the ci test is passed,and i add the cpp/std.str 's test to ensure this case #1146 is fixed correctly in homebrew's llgo

    assert_equal "Hello LLGO by fmt.Println\n" \
                 "Hello LLGO by c.Printf\n" \
                 "Hello LLGO by cpp/std.Str\n",
                 shell_output("#{bin}/llgo run .")
    # Test llgo build
    system bin/"llgo", "build", "-o", "hello", "."
    assert_equal "Hello LLGO by fmt.Println\n" \
                 "Hello LLGO by c.Printf\n" \
                 "Hello LLGO by cpp/std.Str\n",
                 shell_output("./hello")

with the clang++ update , we need use the libc++ , at apt-get need install libc++-19-dev but in the brew,libc++ is with llvm,so we not need addtional depend libc++.

and with the independent libunwind is conflict with libc++,so i change it to use llvm's libunwind

@luoliwoshang luoliwoshang marked this pull request as ready for review June 22, 2025 05:30
@xushiwei xushiwei merged commit 0b233ea into goplus:main Jun 22, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants