Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1104 +/- ##
=======================================
Coverage 87.34% 87.34%
=======================================
Files 29 29
Lines 7225 7225
=======================================
Hits 6311 6311
Misses 849 849
Partials 65 65 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bf7f776 to
d3e228c
Compare
xtool/cppkg/conan.go
Outdated
| return | ||
| } | ||
|
|
||
| err = conanDetect(app, out) |
There was a problem hiding this comment.
should conan detect run every time?
There was a problem hiding this comment.
Since it's only necessary to detect the profile once after installing Conan, should we skip conan profile detect if a profile already exists (i.e., if conan profile show executes successfully)
func conanDetect(app string, out io.Writer) (err error) {
profileCmd := exec.Command(app, "profile", "show")
// ....
profileErr := profileCmd.Run()
if profileErr == nil {
return
}
// ...or would you rather recommend letting the subsequent conan install step fail and prompt the user to run profile detect
| notFoundMgs = append(notFoundMgs, am) | ||
| } | ||
| err = ErrNotFound | ||
| err = fmt.Errorf("app managers not found: %s: %w", strings.Join(notFoundMgs, ", "), ErrNotFound) |
There was a problem hiding this comment.
normally it's an unreachable path. so don't need have a kindly message.
There was a problem hiding this comment.
On Linux, pipx might not be a very commonly used installation method, unlike brew or apt-get. So,I think a prompt like the one below could help reduce confusion during usage:
root@259c7fd049f2:~/llgo/cmd/llgo# llgo cppkg install kspalaiologos/bzip3@1.5.1
From https://github.com/goplus/cppkg
* branch main -> FETCH_HEAD
Already up to date.
panic: app managers not found: brew, pipx: executable file not found in $PATH
d3e228c to
f09a423
Compare
user need install pipx,so when user not install pipx or brew notify error message with app manager.