tuple literal: cb.TupleLit

[xushiwei]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @xushiwei, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to the code generation capabilities by adding a TupleLit method to the CodeBuilder. This method simplifies the creation of tuple literals, providing a more abstract and convenient way to construct these structures. It intelligently infers field types when not explicitly given and translates them into anonymous Go structs, thereby improving the flexibility and expressiveness of the generated code.

Highlights

• New TupleLit Method: A new TupleLit method has been added to the CodeBuilder struct, allowing for the creation of tuple literals in the generated Go code.
• Automatic Type Inference: The TupleLit method can automatically infer the types of the tuple's fields from the values present on the code builder's stack if an explicit type is not provided.
• Tuple Representation: Tuples are internally represented and generated as anonymous Go structs, with fields automatically named X_0, X_1, and so on.
• New Test Case: A TestTupleLit function has been added to validate the correct generation of tuple literals, demonstrating its usage and expected output.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a TupleLit method on CodeBuilder to create tuple literals, which are implemented as struct literals. The implementation correctly infers the tuple type from stack arguments when an explicit type is not provided and then delegates to StructLit. A corresponding test case has been added to verify the new functionality. My review includes a minor refactoring suggestion to improve code conciseness.

[gemini-code-assist]

The if typ == nil block can be simplified by removing the intermediate variables pkg and pkgTypes. You can directly use p.pkg where these variables are used to make the code more concise.

args := p.stk.GetArgs(arity)
		flds := make([]*types.Var, arity)
		for i := 0; i < arity; i++ {
			fldt := types.Default(args[i].Type)
			flds[i] = types.NewField(token.NoPos, p.pkg.Types, "", fldt, false)
		}
		typ = p.pkg.NewTuple(false, flds...)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.10%. Comparing base (72476cb) to head (4d87d11).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #572   +/-   ##
=======================================
  Coverage   96.10%   96.10%           
=======================================
  Files          25       25           
  Lines        6827     6838   +11     
=======================================
+ Hits         6561     6572   +11     
  Misses        198      198           
  Partials       68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[xgopilot]

Code Review Summary

This PR adds documentation improvements and testing for the LookupField and NewTuple functions. The code is well-structured and follows good Go practices. I've posted inline comments for specific areas that warrant attention.

Key findings:

• Documentation could clarify index semantics for virtual field lookups
• Consider adding nil checks for robustness
• Test coverage could be expanded with additional edge cases
• Minor simplification opportunity in test code