-
Notifications
You must be signed in to change notification settings - Fork 33
Open
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.
Description
@saranshdhingra suggested that it would be helpful to add an option to check correctness of the x-goog-api-client header in the retry test support in the testbench.
This might include the following:
- Check that gccl-invocation-id is the same for all retries of a given request
- [if applicable] Check that gccl-attempt-count starts at 1 and gets incremented for each retry.
We could also add a check for x-goog-gcs-idempotency-token when implemented.
This check could be enabled by a data field or query param to the retry_test POST endpoint.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p3Desirable enhancement or fix. May not be included in next release.Desirable enhancement or fix. May not be included in next release.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.‘Nice-to-have’ improvement, new feature or different behavior or design.