Skip to content

[compose][samplecode][1/2]Implement sample code of set credentials in Service Client Class header comment #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
summer-ji-eng merged 16 commits into from
Nov 18, 2020
Merged

[compose][samplecode][1/2]Implement sample code of set credentials in Service Client Class header comment #493

summer-ji-eng merged 16 commits into from
Nov 18, 2020

Conversation

@summer-ji-eng
Copy link
Contributor

@summer-ji-eng summer-ji-eng commented Nov 16, 2020

Implement composing the sample code of setting credentials in service client class header comment.
Example in logging, pubsub

FoobarSettings foobarSettings =
     FoobarSettings.newBuilder()
         .setCredentialsProvider(FixedCredentialsProvider.create(myCredentials))
         .build();
 FoobarClient echoClient =
     FoobarClient.create(echoSettings);

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2020
@summer-ji-eng summer-ji-eng mentioned this pull request Nov 16, 2020
Merged
@miraleung miraleung mentioned this pull request Nov 16, 2020
Merged
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 16, 2020
@summer-ji-eng summer-ji-eng mentioned this pull request Nov 17, 2020
Merged
@summer-ji-eng summer-ji-eng merged commit d78a9d2 into master Nov 18, 2020
@summer-ji-eng summer-ji-eng deleted the service_client_credential_sample_code1 branch November 18, 2020 21:14
summer-ji-eng added a commit that referenced this pull request Nov 18, 2020
@summer-ji-eng
[compose][samplecode][1/2]Implement sample code of set credentials in…
debd146 
… Service Client Class header comment (#493)
miraleung
miraleung reviewed Nov 19, 2020
View reviewed changes
src/test/java/com/google/api/generator/gapic/composer/goldens/IdentityClient.golden
* <pre>{@code
* IdentitySettings identitySettings =
* IdentitySettings.newBuilder()
* .setCredentialsProvider(FixedCredentialsProvider.create("myCredentials"))
Copy link
Contributor

@miraleung miraleung Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed this - this should be some variable, not a string. Example here

suztomo pushed a commit that referenced this pull request Dec 16, 2022
@renovate-bot
deps: update dependency com.google.protobuf:protobuf-java to v3.21.9 (#…
160b427 
…493)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.protobuf:protobuf-java](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf)) | `3.21.8` -> `3.21.9` | [![age](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java/3.21.9/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java/3.21.9/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java/3.21.9/compatibility-slim/3.21.8)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-java/3.21.9/confidence-slim/3.21.8)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>protocolbuffers/protobuf</summary>

### [`v3.21.9`](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.8...v3.21.9)

[Compare Source](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.8...v3.21.9)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xLjUiLCJ1cGRhdGVkSW5WZXIiOiIzNC42LjEifQ==-->
suztomo pushed a commit that referenced this pull request Dec 16, 2022
@release-please
chore(main): release 1.6.7 (#494)
e0b58f3 
🤖 I have created a release *beep* *boop*
---


## [1.6.7](https://togithub.com/googleapis/java-iam/compare/v1.6.6...v1.6.7) (2022-10-31)


### Dependencies

* Update dependency com.google.api:api-common to v2.2.2 ([#497](https://togithub.com/googleapis/java-iam/issues/497)) ([0cb8ba7](https://togithub.com/googleapis/java-iam/commit/0cb8ba78d5c07b64570c65ce14d61db5f08150a8))
* Update dependency com.google.cloud:google-iam-policy to v1.6.6 ([#492](https://togithub.com/googleapis/java-iam/issues/492)) ([bad1c9b](https://togithub.com/googleapis/java-iam/commit/bad1c9b58c4a76017d3665a3ef0887c3481b35e8))
* Update dependency com.google.http-client:google-http-client-jackson2 to v1.42.3 ([#498](https://togithub.com/googleapis/java-iam/issues/498)) ([b68ed60](https://togithub.com/googleapis/java-iam/commit/b68ed601d723dd235dc21e28b22035860a04e6e0))
* Update dependency com.google.protobuf:protobuf-bom to v3.21.9 ([#495](https://togithub.com/googleapis/java-iam/issues/495)) ([2462317](https://togithub.com/googleapis/java-iam/commit/2462317d386a59d07a85c8a752371a09635aa86f))
* Update dependency com.google.protobuf:protobuf-java to v3.21.9 ([#493](https://togithub.com/googleapis/java-iam/issues/493)) ([160b427](https://togithub.com/googleapis/java-iam/commit/160b427f55f8f8ee4d27ba2c5d2d00664d088ff9))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@miraleung miraleung miraleung approved these changes

@xiaozhenliu-gg5 xiaozhenliu-gg5 xiaozhenliu-gg5 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@summer-ji-eng @miraleung @xiaozhenliu-gg5