-
Notifications
You must be signed in to change notification settings - Fork 69
[ggj][engx] build: add all integration tests to pre-commit hook #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
173 changes: 173 additions & 0 deletions
173
...st/java/com/google/api/generator/gapic/composer/goldens/BillingAccountLocationName.golden
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,173 @@ | ||
| package com.google.logging.v2; | ||
|
|
||
| import com.google.api.pathtemplate.PathTemplate; | ||
| import com.google.api.resourcenames.ResourceName; | ||
| import com.google.common.base.Preconditions; | ||
| import com.google.common.collect.ImmutableMap; | ||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.Objects; | ||
| import javax.annotation.Generated; | ||
|
|
||
| // AUTO-GENERATED DOCUMENTATION AND CLASS. | ||
| @Generated("by gapic-generator-java") | ||
| public class BillingAccountLocationName implements ResourceName { | ||
| private static final PathTemplate BILLING_ACCOUNT_LOCATION = | ||
| PathTemplate.createWithoutUrlEncoding( | ||
| "billingAccounts/{billing_account}/locations/{location}"); | ||
| private volatile Map<String, String> fieldValuesMap; | ||
| private final String billingAccount; | ||
| private final String location; | ||
|
|
||
| private BillingAccountLocationName(Builder builder) { | ||
| billingAccount = Preconditions.checkNotNull(builder.getBillingAccount()); | ||
| location = Preconditions.checkNotNull(builder.getLocation()); | ||
| } | ||
|
|
||
| public String getBillingAccount() { | ||
| return billingAccount; | ||
| } | ||
|
|
||
| public String getLocation() { | ||
| return location; | ||
| } | ||
|
|
||
| public static Builder newBuilder() { | ||
| return new Builder(); | ||
| } | ||
|
|
||
| public Builder toBuilder() { | ||
| return new Builder(this); | ||
| } | ||
|
|
||
| public static BillingAccountLocationName of(String billingAccount, String location) { | ||
| return newBuilder().setBillingAccount(billingAccount).setLocation(location).build(); | ||
| } | ||
|
|
||
| public static String format(String billingAccount, String location) { | ||
| return newBuilder().setBillingAccount(billingAccount).setLocation(location).build().toString(); | ||
| } | ||
|
|
||
| public static BillingAccountLocationName parse(String formattedString) { | ||
| if (formattedString.isEmpty()) { | ||
| return null; | ||
| } | ||
| Map<String, String> matchMap = | ||
| BILLING_ACCOUNT_LOCATION.validatedMatch( | ||
| formattedString, | ||
| "BillingAccountLocationName.parse: formattedString not in valid format"); | ||
| return of(matchMap.get("billing_account"), matchMap.get("location")); | ||
| } | ||
|
|
||
| public static List<BillingAccountLocationName> parseList(List<String> formattedStrings) { | ||
| List<BillingAccountLocationName> list = new ArrayList<>(formattedStrings.size()); | ||
| for (String formattedString : formattedStrings) { | ||
| list.add(parse(formattedString)); | ||
| } | ||
| return list; | ||
| } | ||
|
|
||
| public static List<String> toStringList(List<BillingAccountLocationName> values) { | ||
| List<String> list = new ArrayList<>(values.size()); | ||
| for (BillingAccountLocationName value : values) { | ||
| if (Objects.isNull(value)) { | ||
| list.add(""); | ||
| } else { | ||
| list.add(value.toString()); | ||
| } | ||
| } | ||
| return list; | ||
| } | ||
|
|
||
| public static boolean isParsableFrom(String formattedString) { | ||
| return BILLING_ACCOUNT_LOCATION.matches(formattedString); | ||
| } | ||
|
|
||
| @Override | ||
| public Map<String, String> getFieldValuesMap() { | ||
| if (Objects.isNull(fieldValuesMap)) { | ||
| synchronized (this) { | ||
| if (Objects.isNull(fieldValuesMap)) { | ||
| ImmutableMap.Builder<String, String> fieldMapBuilder = ImmutableMap.builder(); | ||
| if (!Objects.isNull(billingAccount)) { | ||
| fieldMapBuilder.put("billing_account", billingAccount); | ||
| } | ||
| if (!Objects.isNull(location)) { | ||
| fieldMapBuilder.put("location", location); | ||
| } | ||
| fieldValuesMap = fieldMapBuilder.build(); | ||
| } | ||
| } | ||
| } | ||
| return fieldValuesMap; | ||
| } | ||
|
|
||
| public String getFieldValue(String fieldName) { | ||
| return getFieldValuesMap().get(fieldName); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return BILLING_ACCOUNT_LOCATION.instantiate( | ||
| "billing_account", billingAccount, "location", location); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (o == this) { | ||
| return true; | ||
| } | ||
| if (o != null || getClass() == o.getClass()) { | ||
| BillingAccountLocationName that = ((BillingAccountLocationName) o); | ||
| return Objects.equals(this.billingAccount, that.billingAccount) | ||
| && Objects.equals(this.location, that.location); | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| int h = 1; | ||
| h *= 1000003; | ||
| h ^= Objects.hashCode(billingAccount); | ||
| h *= 1000003; | ||
| h ^= Objects.hashCode(location); | ||
| return h; | ||
| } | ||
|
|
||
| /** Builder for billingAccounts/{billing_account}/locations/{location}. */ | ||
| public static class Builder { | ||
| private String billingAccount; | ||
| private String location; | ||
|
|
||
| private Builder() {} | ||
|
|
||
| public String getBillingAccount() { | ||
| return billingAccount; | ||
| } | ||
|
|
||
| public String getLocation() { | ||
| return location; | ||
| } | ||
|
|
||
| public Builder setBillingAccount(String billingAccount) { | ||
| this.billingAccount = billingAccount; | ||
| return this; | ||
| } | ||
|
|
||
| public Builder setLocation(String location) { | ||
| this.location = location; | ||
| return this; | ||
| } | ||
|
|
||
| private Builder(BillingAccountLocationName billingAccountLocationName) { | ||
| billingAccount = billingAccountLocationName.billingAccount; | ||
| location = billingAccountLocationName.location; | ||
| } | ||
|
|
||
| public BillingAccountLocationName build() { | ||
| return new BillingAccountLocationName(this); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should we call out that we are running integration test, just to distinguish from the above unit tests.
propose:
Integration tests failedandUnit tests failed.Otherwise, LGTM thanks for putting them together.