Skip to content

[ggj][ast] fix: add varargs to AnonClass and Ref setter methods #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miraleung merged 5 commits into from
Oct 24, 2020
Merged

[ggj][ast] fix: add varargs to AnonClass and Ref setter methods #400

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ceaaddb
fix: refactor requestBuilder into separate method in ServiceClientCla…
miraleung Oct 7, 2020
fba69cb
Merge branch 'master' of github.com:googleapis/gapic-generator-java i…
miraleung Oct 8, 2020
32672f2
fix: merge master
miraleung Oct 21, 2020
bdcb62e
feat: add varargs to AnonClass and ref setter methods
miraleung Oct 21, 2020
42d7fdd
Merge branch 'master' into gp/g0
miraleung Oct 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/com/google/api/generator/engine/ast/AnonymousClassExpr.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import com.google.auto.value.AutoValue;
import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
import java.util.Arrays;
import java.util.Collections;
import java.util.List;

Expand Down Expand Up @@ -45,6 +46,10 @@ public static Builder builder() {
public abstract static class Builder {
public abstract Builder setType(TypeNode type);

public Builder setMethods(MethodDefinition... methods) {
return setMethods(Arrays.asList(methods));
}

public abstract Builder setMethods(List<MethodDefinition> methods);

public abstract Builder setStatements(List<Statement> statements);
Expand Down
7 changes: 6 additions & 1 deletion src/main/java/com/google/api/generator/engine/ast/ConcreteReference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import com.google.auto.value.AutoValue;
import com.google.common.collect.ImmutableList;
import java.util.Arrays;
import java.util.List;
import java.util.Objects;
import javax.annotation.Nullable;
Expand Down Expand Up @@ -210,7 +211,11 @@ public abstract static class Builder {

public abstract Builder setWildcardUpperBound(Reference reference);

public abstract Builder setGenerics(List<Reference> clazzes);
public Builder setGenerics(Reference... references) {
return setGenerics(Arrays.asList(references));
}

public abstract Builder setGenerics(List<Reference> references);

public abstract Builder setIsStaticImport(boolean isStaticImport);

Expand Down
5 changes: 5 additions & 0 deletions src/main/java/com/google/api/generator/engine/ast/VaporReference.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import com.google.auto.value.AutoValue;
import com.google.common.base.Strings;
import com.google.common.collect.ImmutableList;
import java.util.Arrays;
import java.util.List;
import java.util.Objects;
import javax.annotation.Nullable;
Expand Down Expand Up @@ -146,6 +147,10 @@ public abstract static class Builder {

public abstract Builder setUseFullName(boolean useFullName);

public Builder setGenerics(Reference... references) {
return setGenerics(Arrays.asList(references));
}

public abstract Builder setGenerics(List<Reference> clazzes);

public abstract Builder setEnclosingClassName(String enclosingClassName);
Expand Down