Skip to content

deps: update logback version to 1.5.19 #3972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

deps: update logback version to 1.5.19 #3972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions java-showcase/gapic-showcase/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

<properties>
<gapic-showcase.version>0.36.2</gapic-showcase.version>
<slf4j1-logback.version>1.2.13</slf4j1-logback.version>
<slf4j1-logback.version>1.5.19</slf4j1-logback.version>
</properties>

<build>
Expand Down Expand Up @@ -244,13 +244,13 @@
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>1.5.16</version>
<version>1.5.19</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-core</artifactId>
<version>1.5.16</version>
<version>1.5.19</version>
Comment on lines +247 to +253
Copy link

@gemini-code-assist gemini-code-assist bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and ensure version consistency across profiles, consider using the ${slf4j1-logback.version} property for both logback-classic and logback-core instead of hardcoded versions. This centralizes logback version management.

Suggested change
<version>1.5.19</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-core</artifactId>
<version>1.5.16</version>
<version>1.5.19</version>
<version>${slf4j1-logback.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-core</artifactId>
<version>${slf4j1-logback.version}</version>

<scope>test</scope>
</dependency>
</dependencies>
Expand Down Expand Up @@ -333,13 +333,13 @@
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-classic</artifactId>
<version>1.2.13</version>
<version>1.5.19</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-core</artifactId>
<version>1.3.15</version>
<version>1.5.19</version>
Comment on lines +336 to +342
Copy link

@gemini-code-assist gemini-code-assist bot Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency and better maintainability, please use the ${slf4j1-logback.version} property here as well for both logback-classic and logback-core. This makes future updates easier.

Suggested change
<version>1.5.19</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-core</artifactId>
<version>1.3.15</version>
<version>1.5.19</version>
<version>${slf4j1-logback.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>ch.qos.logback</groupId>
<artifactId>logback-core</artifactId>
<version>${slf4j1-logback.version}</version>

<scope>test</scope>
</dependency>
</dependencies>
Expand Down
Loading