-
Notifications
You must be signed in to change notification settings - Fork 69
[ggj][infra][1/5] integration-test: add goldens files for Redis client library #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9ad33d2
add goldens files for redis client lib
xiaozhenliu-gg5 20a548a
add bazel file
xiaozhenliu-gg5 cad27bb
format
xiaozhenliu-gg5 0b740d5
Merge branch 'master' into add_redis_goldens
xiaozhenliu-gg5 589841a
Merge branch 'master' of github.com:googleapis/gapic-generator-java i…
xiaozhenliu-gg5 8e1edfb
add todo comment for Redis client lib goldens
xiaozhenliu-gg5 59d9eb1
Merge branch 'add_redis_goldens' of github.com:googleapis/gapic-gener…
xiaozhenliu-gg5 5477463
add README to integration test goldens folder
xiaozhenliu-gg5 5de4d5a
Merge branch 'master' into add_redis_goldens
xiaozhenliu-gg5 3ec0803
Merge branch 'master' into add_redis_goldens
xiaozhenliu-gg5 8ef95c7
Merge branch 'master' into add_redis_goldens
xiaozhenliu-gg5 a7659fb
Merge branch 'master' into add_redis_goldens
xiaozhenliu-gg5 d36f040
update redis goldens using micro
xiaozhenliu-gg5 bc3f47e
Merge branch 'add_redis_goldens' of github.com:googleapis/gapic-gener…
xiaozhenliu-gg5 b17f380
remove package-info
xiaozhenliu-gg5 53e9083
rename
xiaozhenliu-gg5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Goldens Files For Integration Test | ||
|
|
||
| This folder contains goldens files that are expected to be generated from Java Microgenerator | ||
| against differenct APIs. For example `redis` folder has all the Java source files in the generated | ||
| Redis client library. They are all actual Java files, but used as goldens. | ||
|
|
||
| ## Purpose | ||
|
|
||
| When running integration test for the Java Microgenerator using the below command, | ||
| the goldens files in this folder will be used to compare with the actual generated Java source files. | ||
| If they are not identical, then the integration test will fail. | ||
|
|
||
| ```sh | ||
| bazel test //test/integration:redis_java_gapic | ||
| ``` | ||
|
|
||
| ## How To Update Goldens | ||
|
|
||
| If the actual generated Java source files are not identical with the goldens files, and we want to | ||
| update the goldens using source files. Run the command below to overwrite the goldens files in `redis` folder. | ||
|
|
||
| ```sh | ||
| bazel run //test/integration:redis_goldens_update | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package(default_visibility = ["//visibility:public"]) | ||
|
|
||
| filegroup( | ||
| name = "redis_goldens_files", | ||
| srcs = glob(["*.java"]), | ||
| ) | ||
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.