Skip to content

[ggj][engx] fix: output srcjar path #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miraleung merged 10 commits into from
Sep 4, 2020
Merged

[ggj][engx] fix: output srcjar path #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3dffa8d
feat: parse batching descriptor fields
miraleung Aug 31, 2020
c656ad1
feat: add Field.isMap and map-parsing test
miraleung Aug 31, 2020
bf28e84
feat: add initial batching descriptor field to ServiceStubSettings
miraleung Sep 1, 2020
902fd41
feat: support '? extends Foo' wildcard bounded references
miraleung Sep 1, 2020
8efb572
fix: speed up precommit checks with --disk_cache
miraleung Sep 1, 2020
66a7e1c
feat: add splitException, count{Elements,Bytes} batching descriptor m…
miraleung Sep 1, 2020
1a5c8f8
feat: add GeneralForStatement
miraleung Sep 1, 2020
23b443e
feat: add splitRseponse to batching desc. in ServiceStubSettings
miraleung Sep 2, 2020
381c6e4
fix: output srcjar path
miraleung Sep 2, 2020
1ad1160
Merge branch 'master' into gp/g8
miraleung Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/google/api/generator/Main.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public static void main(String[] args)
ExtensionRegistry registry = ExtensionRegistry.newInstance();
registerAllExtensions(registry);
CodeGeneratorRequest request = CodeGeneratorRequest.parseFrom(System.in, registry);
String outputFilePath = String.format("%stemp-gen.srcjar", request.getParameter());
String outputFilePath = "temp-gen.srcjar";
CodeGeneratorResponse response = Generator.generateGapic(request, outputFilePath);
response.writeTo(System.out);
}
Expand Down
1 change: 0 additions & 1 deletion src/main/java/com/google/api/generator/gapic/composer/BatchingDescriptorComposer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ public static Expr createBatchingDescriptorFieldDeclExpr(
javaMethods.add(createGetBatchPartitionKeyMethod(method, batchingSettings, messageTypes));
javaMethods.add(createGetRequestBuilderMethod(method, batchingSettings));
javaMethods.add(createSplitResponseMethod(method, batchingSettings, messageTypes));

javaMethods.add(createSplitExceptionMethod(method));
javaMethods.add(createCountElementsMethod(method, batchingSettings));
javaMethods.add(createCountByteSMethod(method));
Expand Down