Skip to content

chore: declare test-jar in GAX's testlib artifacts #1474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoeWang1127 merged 8 commits into from
Mar 10, 2023
Merged

chore: declare test-jar in GAX's testlib artifacts #1474

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2484061
chore: add test jar
JoeWang1127 Mar 9, 2023
46b7938
add test jar for showcase
JoeWang1127 Mar 9, 2023
92ad52e
Merge branch 'main' into chore/enable-test-jar
JoeWang1127 Mar 10, 2023
1aa9040
how about duplicating entries?
suztomo Mar 10, 2023
faf89ba
testlib for gax-httpjson too
suztomo Mar 10, 2023
c95c5d4
Merge branch 'chore/enable-test-jar' of github.com:googleapis/gapic-g…
JoeWang1127 Mar 10, 2023
f3b8be5
add source comment
JoeWang1127 Mar 10, 2023
f106572
Merge branch 'main' into chore/enable-test-jar
JoeWang1127 Mar 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions gapic-generator-java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@
<dependency>
<groupId>com.google.api</groupId>
<artifactId>gax</artifactId>
<type>test-jar</type>
Copy link
Member

@suztomo suztomo Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add source code comment why this test-jar is important?

Copy link
Contributor Author

@JoeWang1127 JoeWang1127 Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

<classifier>testlib</classifier>
</dependency>
<dependency>
Expand All @@ -383,6 +384,7 @@
<dependency>
<groupId>com.google.api</groupId>
<artifactId>gax-grpc</artifactId>
<type>test-jar</type>
<classifier>testlib</classifier>
</dependency>
<dependency>
Expand All @@ -392,6 +394,7 @@
<dependency>
<groupId>com.google.api</groupId>
<artifactId>gax-httpjson</artifactId>
<type>test-jar</type>
<classifier>testlib</classifier>
</dependency>
<dependency>
Expand Down
22 changes: 22 additions & 0 deletions gax-java/gax-bom/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-shared-config</artifactId>
<version>1.5.5</version>
<relativePath/>
</parent>

<developers>
Expand Down Expand Up @@ -48,12 +49,26 @@
<groupId>com.google.api</groupId>
<artifactId>gax</artifactId>
<version>2.23.3-SNAPSHOT</version><!-- {x-version-update:gax:current} -->
<type>test-jar</type>
Copy link
Member

@suztomo suztomo Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JoeWang1127 'dependencies.dependency.version' for com.google.api:gax:jar:testlib is missing. @ line 80, column 21 came from the BOM's declaration of the artifacts. Do you really need that?

Copy link
Contributor Author

@JoeWang1127 JoeWang1127 Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line is needed to bring the test code.

Copy link
Member

@suztomo suztomo Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A BOM doesn't determine what code goes to JAR file.

Copy link
Contributor Author

@JoeWang1127 JoeWang1127 Mar 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an error in gapic-generator-java module if I delete this line and reload the project:

'dependencies.dependency.version' for com.google.api:gax-grpc:test-jar:testlib is missing.

Copy link
Member

@suztomo suztomo Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK it’s for IntelliJ. Then it makes sense.

<classifier>testlib</classifier>
</dependency>
<dependency>
<groupId>com.google.api</groupId>
<artifactId>gax</artifactId>
<version>2.23.3-SNAPSHOT</version><!-- {x-version-update:gax:current} -->
<classifier>testlib</classifier>
Copy link
Member

@suztomo suztomo Mar 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying an additional entry that does not carry "test-jar".

Copy link
Contributor Author

@JoeWang1127 JoeWang1127 Mar 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suztomo thanks for the help.

</dependency>
<dependency>
<groupId>com.google.api</groupId>
<artifactId>gax-grpc</artifactId>
<version>2.23.3-SNAPSHOT</version><!-- {x-version-update:gax-grpc:current} -->
</dependency>
<dependency>
<groupId>com.google.api</groupId>
<artifactId>gax-grpc</artifactId>
<version>2.23.3-SNAPSHOT</version><!-- {x-version-update:gax-grpc:current} -->
<type>test-jar</type>
<classifier>testlib</classifier>
</dependency>
<dependency>
<groupId>com.google.api</groupId>
Expand All @@ -66,6 +81,13 @@
<artifactId>gax-httpjson</artifactId>
<version>0.108.3-SNAPSHOT</version><!-- {x-version-update:gax-httpjson:current} -->
</dependency>
<dependency>
<groupId>com.google.api</groupId>
<artifactId>gax-httpjson</artifactId>
<version>0.108.3-SNAPSHOT</version><!-- {x-version-update:gax-httpjson:current} -->
<type>test-jar</type>
<classifier>testlib</classifier>
</dependency>
<dependency>
<groupId>com.google.api</groupId>
<artifactId>gax-httpjson</artifactId>
Expand Down