-
Notifications
You must be signed in to change notification settings - Fork 69
feat: Add SuperObjectValue and unit test #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
b0d29d3
Add SuperObjectValue and unit test
summer-ji-eng bb29ab3
fix: clean up composer methods (#138)
miraleung f4dab91
[ggj] feat: add starter for ServiceClientTest generation (#139)
miraleung 5382ec9
correct test name and add overwrite
summer-ji-eng 7154d99
feat: add ThisObjectValue (#137)
summer-ji-eng 612dcd5
rebase master
summer-ji-eng a5b9837
correct test name and add overwrite
summer-ji-eng 93ba052
rebase upstream
summer-ji-eng 21c98a1
Add import write test
summer-ji-eng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
54 changes: 54 additions & 0 deletions
54
src/main/java/com/google/api/generator/engine/ast/SuperObjectValue.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // Copyright 2020 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.api.generator.engine.ast; | ||
|
|
||
| import com.google.auto.value.AutoValue; | ||
| import com.google.common.base.Preconditions; | ||
|
|
||
| @AutoValue | ||
| public abstract class SuperObjectValue implements ObjectValue { | ||
| private static final String SUPER_VALUE = "super"; | ||
|
|
||
| @Override | ||
| public abstract TypeNode type(); | ||
|
|
||
| @Override | ||
| public String value() { | ||
| return SUPER_VALUE; | ||
| } | ||
|
|
||
| private static Builder builder() { | ||
| return new AutoValue_SuperObjectValue.Builder(); | ||
| } | ||
|
|
||
| public static SuperObjectValue withType(TypeNode type) { | ||
| return builder().setType(type).build(); | ||
| } | ||
|
|
||
| @AutoValue.Builder | ||
| abstract static class Builder { | ||
| abstract Builder setType(TypeNode type); | ||
|
|
||
| abstract SuperObjectValue autoBuild(); | ||
|
|
||
| private SuperObjectValue build() { | ||
| SuperObjectValue superObjectValue = autoBuild(); | ||
| Preconditions.checkState( | ||
| TypeNode.isReferenceType(superObjectValue.type()), | ||
| "super can only refer to object types"); | ||
| return superObjectValue; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 changes: 52 additions & 0 deletions
52
src/test/java/com/google/api/generator/engine/ast/SuperObjectValueTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // Copyright 2020 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package com.google.api.generator.engine.ast; | ||
|
|
||
| import static org.junit.Assert.assertThrows; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| public class SuperObjectValueTest { | ||
|
|
||
| @Test | ||
| public void validSuperObjectValue_basic() { | ||
| VaporReference ref = | ||
| VaporReference.builder() | ||
| .setName("Student") | ||
| .setPakkage("com.google.example.examples.v1") | ||
| .build(); | ||
| TypeNode typeNode = TypeNode.withReference(ref); | ||
| SuperObjectValue.withType(typeNode); | ||
| // No exception thrown, we're good. | ||
| } | ||
|
|
||
| @Test | ||
| public void invalidSuperObjectValue_nonReferenceType() { | ||
| assertThrows( | ||
| IllegalStateException.class, | ||
| () -> { | ||
| SuperObjectValue.withType(TypeNode.DOUBLE); | ||
| }); | ||
| } | ||
|
|
||
| @Test | ||
| public void invalidSuperObjectValue_nullType() { | ||
| assertThrows( | ||
| IllegalStateException.class, | ||
| () -> { | ||
| SuperObjectValue.withType(TypeNode.NULL); | ||
| }); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.