Skip to content

Conversation

@meltsufin
Copy link
Member

@meltsufin meltsufin requested a review from a team as a code owner January 24, 2023 16:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information


#### Environment details

1. Specify the API at the beginning of the title. For example, "BigQuery: ...").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to specify API for issues in gapic-generator-java? It makes sense for the SDK monorepo, but maybe something like Specify the module makes more sense for this repo? Or maybe we don't need this step? Since technically all submodules are core components of the generator and we don't have to tell the differences?

@ddixit14
Copy link
Contributor

ddixit14 commented Jan 24, 2023

@meltsufin I just added these templates in my PR as well, without realizing you opened this PR. Should I remove them ?

@meltsufin
Copy link
Member Author

@ddixit14 closing in favor of #1265.

@meltsufin meltsufin closed this Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants