Skip to content

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Feb 10, 2021

Delegates the logic of finding the latestTag to the individual releaser. In order to support the stable branch names, we need to leverage the detection of the version from the merged pull request.

This is breaking as it moves the implementation of GitHub#latestTag to ReleasePR.

Fixes #756

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 10, 2021
@chingor13 chingor13 changed the title refactor: move latestTag logic to ReleasePR refactor!: move latestTag logic to ReleasePR Feb 10, 2021
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #758 (59b9c87) into master (f41a777) will decrease coverage by 0.77%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #758      +/-   ##
==========================================
- Coverage   90.95%   90.17%   -0.78%     
==========================================
  Files          57       57              
  Lines        7426     7515      +89     
  Branches      719      720       +1     
==========================================
+ Hits         6754     6777      +23     
- Misses        671      737      +66     
  Partials        1        1              
Impacted Files Coverage Δ
src/github.ts 83.75% <ø> (-3.69%) ⬇️
src/releasers/ruby.ts 35.00% <0.00%> (ø)
src/release-pr.ts 90.78% <85.08%> (-1.32%) ⬇️
src/releasers/go-yoshi.ts 92.96% <100.00%> (ø)
src/releasers/java-bom.ts 92.88% <100.00%> (ø)
src/releasers/java-yoshi.ts 87.31% <100.00%> (ø)
src/releasers/node.ts 100.00% <100.00%> (ø)
src/releasers/ocaml.ts 94.11% <100.00%> (ø)
src/releasers/php-yoshi.ts 92.99% <100.00%> (ø)
src/releasers/python.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f41a777...eefe88f. Read the comment docs.

@chingor13 chingor13 marked this pull request as ready for review February 10, 2021 23:48
@chingor13 chingor13 requested a review from a team as a code owner February 10, 2021 23:48
@chingor13 chingor13 changed the title refactor!: move latestTag logic to ReleasePR refactor: move latestTag logic to ReleasePR Feb 10, 2021
@chingor13 chingor13 changed the title refactor: move latestTag logic to ReleasePR refactor!: move latestTag logic to ReleasePR Feb 11, 2021
@bcoe bcoe merged commit 746d1c8 into googleapis:master Feb 11, 2021
@release-please release-please bot mentioned this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

latestTag() does not find stable-branch name without a version in the branch name

2 participants