Skip to content

fix: Update version string in Terraform submodule README files #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bcoe merged 2 commits into from
Nov 25, 2020
Merged

fix: Update version string in Terraform submodule README files #640

bcoe merged 2 commits into from
Nov 25, 2020

Conversation

@morgante
Copy link
Contributor

@morgante morgante commented Nov 24, 2020 •
edited
Loading

Fixes #637.

@morgante morgante requested a review from a team as a code owner November 24, 2020 23:21
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 24, 2020
@morgante morgante changed the title Stage Terraform change [Draft] Update versions in Terraform submodule README files. Nov 24, 2020
@morgante morgante marked this pull request as draft November 24, 2020 23:22
@codecov
Copy link

codecov bot commented Nov 24, 2020 •
edited
Loading

Codecov Report

Merging #640 (18965ec) into master (178bfb6) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #640      +/-   ##
==========================================
+ Coverage   81.65%   81.67%   +0.02%     
==========================================
  Files          46       46              
  Lines        5379     5385       +6     
  Branches      428      429       +1     
==========================================
+ Hits         4392     4398       +6     
  Misses        986      986              
  Partials        1        1
Impacted Files Coverage Δ
src/releasers/terraform-module.ts 91.73% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178bfb6...18965ec. Read the comment docs.

bharathkkb
bharathkkb reviewed Nov 25, 2020
View reviewed changes
@morgante morgante force-pushed the fix/tf-submodules branch 3 times, most recently from c3c62c0 to 67970f5 Compare November 25, 2020 04:03
@morgante morgante marked this pull request as ready for review November 25, 2020 04:03
@morgante morgante changed the title [Draft] Update versions in Terraform submodule README files. Update version string in Terraform submodule README files. Nov 25, 2020
@morgante morgante changed the title Update version string in Terraform submodule README files. fix: Update version string in Terraform submodule README files Nov 25, 2020
@bcoe
Copy link

bcoe commented Nov 25, 2020

thanks 🥳

@bcoe bcoe merged commit a1d3408 into googleapis:master Nov 25, 2020
@XxSonicGhostxX XxSonicGhostxX mentioned this pull request Mar 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@bharathkkb bharathkkb bharathkkb left review comments

@bcoe bcoe bcoe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Terraform] Update submodule README versions

3 participants

@morgante @bcoe @bharathkkb