fix: propagate blob.generation in Bucket.delete_blobs #817
Conversation
product-auto-label
bot
added
size: m
cojenco
added
the
do not merge
| if not isinstance(blob_name, str): | ||
| blob_name = blob.name | ||
| if blob.generation: | ||
| generation = blob.generation |
There was a problem hiding this comment.
I'm still uncertain whether we should change behavior in this way, though I do agree the current behavior is bad. If we do make this change, can we skip the "take the name from the blob and recreate it" runaround and just run delete on the blob objects directly? This seems unnecessarily convoluted.
There was a problem hiding this comment.
I understand your concerns. Unfortunately, with the current setup, it will be difficult to bypass "take the name from the blob...". Reasons being (1) params blobs can be a list of str blob_name OR blob instances, (2) bucket.delete_blob() only takes str blob_name whereas blob.delete() requires a blob instance.
There was a problem hiding this comment.
As discussed, I'm wondering if adding a flag to the method will better ensure backwards compatibility, but I'm also concerned that it will make this even more convoluted >"<
|
superseded by #840 |
3 participants
Fixes #814 🦕