Skip to content

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Sep 22, 2020

google-cloud-core version 1.4.2 populates prettyPrint=false by
default. Update the connection tests to expect a value for
prettyPrint.

This PR also serves to test that the changes in googleapis/python-cloud-core#28 do not break this library.

`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by
default. Update the connection tests to expect a value for
`prettyPrint`.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 22, 2020
@tswast tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 22, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Sep 23, 2020
@tswast tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 5, 2020
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 6, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 6, 2020
@tseaver tseaver merged commit 6cc4a41 into master Oct 6, 2020
@tseaver tseaver deleted the google-cloud-core-1.4.2rc1 branch October 6, 2020 21:52
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by
default. Update the connection tests to expect a value for
`prettyPrint`.

Co-authored-by: Tres Seaver <[email protected]>
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by
default. Update the connection tests to expect a value for
`prettyPrint`.

Co-authored-by: Tres Seaver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants