Skip to content

fix: Segmentation fault in tink while writing data #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pulkit0110 merged 3 commits into from
Jun 13, 2025
Merged

fix: Segmentation fault in tink while writing data #1490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b19bc2a
fix: Segmentation fault in tink while writing data
Pulkit0110 Jun 5, 2025
d1755a5
add unit tests
Pulkit0110 Jun 9, 2025
67921b0
Merge branch 'main' into integer-vulnerability-fix
Pulkit0110 Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion google/cloud/storage/_media/requests/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,6 @@ def _write_to_stream(self, response):
msg += content_length_msg
raise DataCorruption(response, msg)


def consume(
self,
transport,
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/storage/fileio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ def write(self, b):
self._buffer.seek(0, io.SEEK_END)
pos = self._buffer.write(b)
self._buffer.seek(bookmark)
return self._cursor + pos
return pos

def read(self, size=-1):
"""Read and move the cursor."""
Expand Down
6 changes: 4 additions & 2 deletions tests/unit/test_fileio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,12 +367,14 @@ def test_write(self, mock_warn):

# Write under chunk_size. This should be buffered and the upload not
# initiated.
writer.write(TEST_BINARY_DATA[0:4])
w1 = writer.write(TEST_BINARY_DATA[0:4])
self.assertEqual(w1, 4)
blob._initiate_resumable_upload.assert_not_called()

# Write over chunk_size. This should result in upload initialization
# and multiple chunks uploaded.
writer.write(TEST_BINARY_DATA[4:32])
w2 = writer.write(TEST_BINARY_DATA[4:32])
self.assertEqual(w2, 28)
blob._initiate_resumable_upload.assert_called_once_with(
blob.bucket.client,
writer._buffer,
Expand Down