Skip to content

refactor: remove unnecessary override methods #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larkee merged 1 commit into from
May 25, 2021
Merged

refactor: remove unnecessary override methods #75

larkee merged 1 commit into from
May 25, 2021

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented May 24, 2021

No description provided.

@HemangChothani HemangChothani requested a review from larkee May 24, 2021 08:38
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 24, 2021
larkee
larkee reviewed May 24, 2021
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although aren't there overrides in NumericTest and TextTest which would be similarly refactored?

@HemangChothani
Copy link
Contributor Author

HemangChothani commented May 24, 2021

For TextTest covered in PR #67 and need to override NumericTest tests as don't have any other option to resolve the limitation of spanner that a table with no primary key columns can have only one row.

@larkee larkee merged commit 1b9e6c2 into main May 25, 2021
@larkee larkee mentioned this pull request May 25, 2021
Merged
@IlyaFaer IlyaFaer deleted the refactor_code branch November 17, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larkee larkee larkee approved these changes

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HemangChothani @larkee