Skip to content

test: add text compliance tests #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larkee merged 10 commits into from
May 12, 2021
Merged

test: add text compliance tests #36

larkee merged 10 commits into from
May 12, 2021

Conversation

@HemangChothani
Copy link
Contributor

@HemangChothani HemangChothani commented Mar 25, 2021

No description provided.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2021
@HemangChothani
Copy link
Contributor Author

HemangChothani commented Mar 25, 2021

Failed tests are fixed in #23 PR.

@HemangChothani HemangChothani requested a review from larkee March 25, 2021 14:24
@skuruppu skuruppu requested a review from vi3k6i5 April 29, 2021 04:54
vi3k6i5
vi3k6i5 reviewed May 4, 2021
View reviewed changes
vi3k6i5
vi3k6i5 reviewed May 4, 2021
View reviewed changes
@HemangChothani HemangChothani mentioned this pull request May 5, 2021
Merged
@HemangChothani
Copy link
Contributor Author

HemangChothani commented May 5, 2021

One test and cleanup of two tests are failing which will be resolved by respective PRs #23, #68.

larkee
larkee approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@larkee larkee merged commit f3ca437 into main May 12, 2021
@IlyaFaer IlyaFaer deleted the text_compliance_test branch November 17, 2021 10:03
@IlyaFaer IlyaFaer restored the text_compliance_test branch November 17, 2021 10:03
@IlyaFaer IlyaFaer deleted the text_compliance_test branch November 17, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larkee larkee larkee approved these changes

+1 more reviewer

@vi3k6i5 vi3k6i5 vi3k6i5 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HemangChothani @vi3k6i5 @larkee