fix: use empty schema name by default #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
March 15, 2021 12:38
google-cla
bot
added
the
cla: yes
IlyaFaer
commented
Mar 19, 2021
| WHERE table_schema = '{}' | ||
| """.format( | ||
| schema | ||
| schema or "" |
Contributor
Author
There was a problem hiding this comment.
By default schema arg is None, so it tried to search for tables with schema 'None'. Not sure how I've written this, it's not smart at all. Fixing it.
IlyaFaer
commented
Mar 19, 2021
| answer = ["users", "user_tmp", "email_addresses", "dingalings"] | ||
| eq_(table_names, answer) | ||
| else: | ||
| answer = ["dingalings", "email_addresses", "user_tmp", "users"] |
Contributor
Author
There was a problem hiding this comment.
user_tmp is a temporary table, adding it into the expected results
Contributor
Author
Merged
larkee
reviewed
Mar 23, 2021
Contributor
larkee
left a comment
larkee
left a comment
There was a problem hiding this comment.
Changes introduced in this PR (i.e. schema name and table name test override) LGTM 👍
Approval pending the base PR
Contributor
|
Merging to unblock further work |
AVaksman
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is based on another: #24