Skip to content

Conversation

@daniel-sanche
Copy link
Contributor

This PR adds python 3.14 support to the python-logging package.

Expanding off of Omair's work here: #1055

ohmayr and others added 30 commits October 10, 2025 23:03
@daniel-sanche daniel-sanche requested review from a team as code owners December 12, 2025 23:03
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 12, 2025
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Dec 12, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @daniel-sanche, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive support for Python 3.14 to the python-logging package. It involves updating build configurations, test environments, dependency specifications, and documentation to ensure full compatibility and continuous integration for the new Python version. The changes also include minor refinements to system test cleanup procedures and multiprocessing handling.

Highlights

  • Python 3.14 Support: Comprehensive support for Python 3.14 has been integrated across the project, enabling the package to run and be tested against the latest Python version.
  • Build and Test Infrastructure Updates: New Kokoro configurations and modifications to noxfile.py have been implemented to facilitate continuous integration and testing for Python 3.14 samples and unit tests.
  • Dependency Management: The setup.py file has been updated to include a specific grpcio version requirement for Python 3.14, and a new constraints file (testing/constraints-3.14.txt) has been added to manage dependencies for Python 3.14 unit tests.
  • Documentation and Metadata: The CONTRIBUTING.rst file and setup.py classifiers have been updated to officially reflect and document the added support for Python 3.14.
  • Multiprocessing Refinement in System Tests: System tests in test_system.py now explicitly use multiprocessing.get_context('fork') for process creation, enhancing robustness and compatibility, particularly for newer Python versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for Python 3.14 by updating CI configurations, dependencies, and documentation. The changes are mostly straightforward and correct. I've pointed out a potential inconsistency in the system test Python version configuration in .librarian/generator-input/librarian.py. I've also suggested a couple of minor improvements for consistency and clarity in noxfile.py and setup.py. The updates to system tests to explicitly use the 'fork' context for multiprocessing are a good addition for cross-platform compatibility.

@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 13, 2025
@daniel-sanche daniel-sanche added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the googleapis/python-logging API. kokoro:run Add this label to force Kokoro to re-run the tests. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants