Skip to content

fix: expect 'DocumentSnapshot.__hash__' to expect 'DatetimeWithNanosecons' #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Arushi201296 wants to merge 3 commits into from
Closed

fix: expect 'DocumentSnapshot.__hash__' to expect 'DatetimeWithNanosecons' #392

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2d3195
fix: Issue-391. Modify __hash__ method of DocumentSnapshot. Follow pr…
Arushi201296 Jul 14, 2021
1a58e21
Merge branch 'master' into issue-391-fix
Arushi201296 Jul 14, 2021
9877dd0
Merge branch 'main' into issue-391-fix
crwilcox Sep 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions google/cloud/firestore_v1/base_document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,8 @@ def __eq__(self, other):
return self._reference == other._reference and self._data == other._data

def __hash__(self):
seconds = int(self.update_time.timestamp())
nanos = self.update_time.nanosecond
seconds = int(self.update_time.seconds)
nanos = self.update_time.nanos
return hash(self._reference) + hash(seconds) + hash(nanos)

@property
Expand Down