Skip to content

chore: protect v3.x.x branch #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tswast merged 3 commits into from
Jul 27, 2021
Merged

chore: protect v3.x.x branch #816

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c8f082
chore: protect v3.x.x branch
tswast Jul 27, 2021
ca04a94
force pattern to be a string
tswast Jul 27, 2021
66e446c
simplify branch name
tswast Jul 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/sync-repo-settings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
branchProtectionRules:
# Identifies the protection rule pattern. Name of the branch to be protected.
# Defaults to `master`
- pattern: master
- pattern: '{master,v3.x.x}'
Copy link
Contributor

@tseaver tseaver Jul 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm not sure of the syntax -- are you planning that the actual branch name will be v3.x.x? ISTM that v3 would be clearer: it is the branch from which 3.x.x releases will be made.

Copy link
Contributor Author

@tswast tswast Jul 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I was planning v3.x.x to be the actual name. v3 SGTM, though.

requiredStatusCheckContexts:
- 'Kokoro'
- 'Kokoro snippets-3.8'
Expand Down