Skip to content

tests: split out snippets builds #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcf-merge-on-green merged 5 commits into from
Oct 16, 2020
Merged

tests: split out snippets builds #219

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3e1b7bf
tests: split out snippets builds
tseaver Aug 10, 2020
5f1d2b1
Merge branch 'master' into 191-split-out-snippets-builds
tswast Oct 16, 2020
2338e1b
change name to match internal CL 337405571
tswast Oct 16, 2020
82557ee
typo
tswast Oct 16, 2020
a54cda4
match internal CL 337405571
tswast Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .kokoro/presubmit/presubmit.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@ env_vars: {
key: "RUN_SYSTEM_TESTS"
value: "false"
}
env_vars: {
key: "RUN_SNIPPETS"
Copy link
Contributor

@tmatsuo tmatsuo Oct 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to allow this envvar in the Kokoro config in google3.
Also how about RUN_SNIPPETS_TESTS for consistensy?

Copy link
Contributor

@tswast tswast Oct 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RUN_SNIPPETS_TESTS sounds good to me

Copy link
Contributor

@tmatsuo tmatsuo Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to the Kokoro side configuration files.

value: "false"
}
7 changes: 7 additions & 0 deletions .kokoro/presubmit/snippets-2.7.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Format: //devtools/kokoro/config/proto/build.proto

# Only run this nox session.
env_vars: {
key: "NOX_SESSION"
value: "snippets-2.7"
}
7 changes: 7 additions & 0 deletions .kokoro/presubmit/snippets-3.8.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Format: //devtools/kokoro/config/proto/build.proto

# Only run this nox session.
env_vars: {
key: "NOX_SESSION"
value: "snippets-3.8"
}
4 changes: 4 additions & 0 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,10 @@ def system(session):
def snippets(session):
"""Run the snippets test suite."""

# Check the value of `RUN_SNIPPETS` env var. It defaults to true.
if os.environ.get("RUN_SNIPPETS", "true") == "false":
session.skip("RUN_SNIPPETS is set to false, skipping")

# Sanity check: Only run snippets tests if the environment variable is set.
if not os.environ.get("GOOGLE_APPLICATION_CREDENTIALS", ""):
session.skip("Credentials must be set via environment variable.")
Expand Down