Skip to content

deps: add "extra" for IPython, exclude bad IPython release #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tswast merged 5 commits into from
Mar 1, 2022
Merged

deps: add "extra" for IPython, exclude bad IPython release #1151

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6db7994
deps: add "extra" for IPython, exclude bad IPython release
tswast Mar 1, 2022
5488a04
skip magics tests when IPython not installed
tswast Mar 1, 2022
c98770c
sort importorskips
tswast Mar 1, 2022
cf11a82
add 3.10 prerelease session
tswast Mar 1, 2022
81e4126
add continuous session
tswast Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,6 @@ def default(session, install_extras=True):
install_target = "."
session.install("-e", install_target, "-c", constraints_path)

session.install("ipython", "-c", constraints_path)

# Run py.test against the unit tests.
session.run(
"py.test",
Expand Down Expand Up @@ -119,7 +117,6 @@ def unit_noextras(session):
def mypy(session):
"""Run type checks with mypy."""
session.install("-e", ".[all]")
session.install("ipython")
session.install(MYPY_VERSION)

# Just install the dependencies' type info directly, since "mypy --install-types"
Expand All @@ -138,7 +135,6 @@ def pytype(session):
# https://github.com/googleapis/python-bigquery/issues/655
session.install("attrs==20.3.0")
session.install("-e", ".[all]")
session.install("ipython")
session.install(PYTYPE_VERSION)
session.run("pytype")

Expand Down Expand Up @@ -180,7 +176,6 @@ def system(session):
else:
extras = "[all]"
session.install("-e", f".{extras}", "-c", constraints_path)
session.install("ipython", "-c", constraints_path)

# Run py.test against the system tests.
session.run("py.test", "--quiet", os.path.join("tests", "system"), *session.posargs)
Expand Down Expand Up @@ -355,7 +350,7 @@ def blacken(session):
def docs(session):
"""Build the docs."""

session.install("ipython", "recommonmark", "sphinx==4.0.1", "sphinx_rtd_theme")
session.install("recommonmark", "sphinx==4.0.1", "sphinx_rtd_theme")
session.install("google-cloud-storage")
session.install("-e", ".[all]")

Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
"geopandas": ["geopandas>=0.9.0, <1.0dev", "Shapely>=1.6.0, <2.0dev"],
"pandas": ["pandas>=0.24.2"] + pyarrow_dep,
"bignumeric_type": pyarrow_dep,
"ipython": ["ipython>=7.0.1,!=8.1.0"],
"tqdm": ["tqdm >= 4.7.4, <5.0.0dev"],
"opentelemetry": [
"opentelemetry-api >= 1.1.0",
Expand Down
1 change: 1 addition & 0 deletions testing/constraints-3.6.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ google-cloud-bigquery-storage==2.0.0
google-cloud-core==1.4.1
google-resumable-media==0.6.0
grpcio==1.38.1
ipython==7.0.1
opentelemetry-api==1.1.0
opentelemetry-instrumentation==0.20b0
opentelemetry-sdk==1.1.0
Expand Down