Skip to content

Fix array of floats bug #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tswast merged 2 commits into from
Feb 23, 2018
Merged

Fix array of floats bug #134

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec28045
Fix array of floats bug
jasonqng Feb 21, 2018
84582b6
Update changelog
jasonqng Feb 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pandas_gbq/gbq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,8 @@ def _parse_data(schema, rows):
col_names = [str(field['name']) for field in fields]
col_dtypes = [
dtype_map.get(field['type'].upper(), object)
if field['mode'] != 'repeated'
else object
for field in fields
]
page_array = np.zeros((len(rows),), dtype=lzip(col_names, col_dtypes))
Expand Down
8 changes: 8 additions & 0 deletions pandas_gbq/tests/test_gbq.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -973,6 +973,14 @@ def test_array_agg(self):
tm.assert_frame_equal(df, DataFrame([["a", [1, 3]], ["b", [2]]],
columns=["letter", "numbers"]))

def test_array_of_floats(self):
query = """select [1.1, 2.2, 3.3] as a, 4 as b"""
df = gbq.read_gbq(query, project_id=_get_project_id(),
private_key=_get_private_key_path(),
dialect='standard')
tm.assert_frame_equal(df, DataFrame([[[1.1, 2.2, 3.3], 4]],
columns=["a", "b"]))


class TestToGBQIntegrationWithServiceAccountKeyPath(object):
# Changes to BigQuery table schema may take up to 2 minutes as of May 2015
Expand Down