Skip to content

Conversation

@tswast
Copy link
Collaborator

@tswast tswast commented Dec 21, 2017

The actual change was done in #25, but I missed that #7 exists when I updated the changelog.

Closes #7

@codecov-io
Copy link

codecov-io commented Dec 21, 2017

Codecov Report

Merging #100 into master will decrease coverage by 44.66%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #100       +/-   ##
===========================================
- Coverage   73.64%   28.97%   -44.67%     
===========================================
  Files           4        4               
  Lines        1491     1491               
===========================================
- Hits         1098      432      -666     
- Misses        393     1059      +666
Impacted Files Coverage Δ
pandas_gbq/gbq.py 20.55% <0%> (-56.36%) ⬇️
pandas_gbq/tests/test_gbq.py 27.98% <0%> (-54.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea1f7f...bbd0c40. Read the comment docs.

@tswast tswast requested review from jreback and parthea December 21, 2017 18:15
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tswast tswast merged commit 4cab83c into googleapis:master Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants