Skip to content

Fix: improve GetFilesResponse interface #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 14, 2024
Merged

Fix: improve GetFilesResponse interface #2466

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5d8944
Fix: improve GetFilesResponse interface
olishevskii May 12, 2024
8c564bb
fix: Improve GetFilesResponse interface
olishevskii May 13, 2024
7352576
Fix: improve GetFilesResponse interface
olishevskii May 14, 2024
cc267b7
Fix: improve GetFilesResponse interface
olishevskii May 14, 2024
d463714
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bucket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ interface MetadataOptions {
ifMetagenerationNotMatch?: number | string;
}

export type GetFilesResponse = [File[], {}, unknown];
export type GetFilesResponse = [File[], (GetFilesOptions | GetFilesCallback) & Partial<Pick<GetFilesOptions, 'pageToken'>>, unknown];
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 May 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can omit GetFilesCallback, query can only be GetFilesOptions or an empty object. It will never get assigned the callback.

Copy link
Contributor Author

@olishevskii olishevskii May 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fixed it.

export interface GetFilesCallback {
(
err: Error | null,
Expand Down