Skip to content

Conversation

@release-please
Copy link
Contributor

@release-please release-please bot commented Dec 2, 2020

🤖 I have created a release *beep* *boop*

9.0.0 (2020-12-04)

⚠ BREAKING CHANGES

Bug Fixes

  • only apply logName to filter when not already present (#962) (f1fbbc4)
  • deps: roll back dependency @google-cloud/logging to ^8.1.1 (#961) (1fa8cd3)
  • users can log httprequest logs without providing a log message (#942) (d72a296)

Performance Improvements

  • getEntries filters 24 hour timestamp by default (#955) (3d63d5f)

This PR was generated with Release Please.

@release-please release-please bot requested review from a team as code owners December 2, 2020 20:12
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2020
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging API. label Dec 2, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2020
@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #963 (49241ed) into master (8230e9f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #963   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          18       18           
  Lines       12985    12985           
  Branches      399      399           
=======================================
  Hits        12776    12776           
  Misses        207      207           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8230e9f...49241ed. Read the comment docs.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2020
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2020
@stephenplusplus
Copy link
Contributor

@nicoleczhu I saw your approval, but just wanted to double check-- is it safe to merge this without waiting to combine with any other changes?

@freelerobot
Copy link
Contributor

@nicoleczhu I saw your approval, but just wanted to double check-- is it safe to merge this without waiting to combine with any other changes?

It's a great question. We don't have any more breaking changes coming up (though never say never...).
And this one already contains 2 breaking fixes that were bundled for this release. I cleared it with @bcoe , but wanted a Yoshi person to merge this one based on your preferred release schedules. Do you guys prefer to do these major releases on Monday/Tues only? Just want to be extra careful here

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 4, 2020
@stephenplusplus
Copy link
Contributor

@nicoleczhu that was a great point. Things look safe to me to release, so I'll kick it off now. Thanks!

@stephenplusplus stephenplusplus merged commit 040373c into master Dec 7, 2020
@stephenplusplus stephenplusplus deleted the release-v9.0.0 branch December 7, 2020 14:18
@yoshi-automation
Copy link
Contributor

@release-tool-publish-reporter
Copy link

The release build has started, the log can be viewed here. 🌻

@release-tool-publish-reporter
Copy link

🥚 You hatched a release! The release build finished successfully! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the googleapis/nodejs-logging API. autorelease: published cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants