Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Aug 23, 2018

This Pull Request updates dependency @google-cloud/common (source) from ^0.22.0 to ^0.23.0

Note: This PR was created on a configured schedule ("after 9am and before 3pm") and will not receive updates outside those times.

Details
Release Notes

v0.23.0

Compare Source

Fixes
  • fix: move repo-tools to dev dependencies (#​218)
Features
  • feat: make HTTP dependency configurable (#​210)
Keepin the lights on


This PR has been generated by Renovate Bot.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2018
@codecov
Copy link

codecov bot commented Aug 23, 2018

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #89   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         241    241           
=====================================
  Hits          241    241

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5da8ec4...d165fc9. Read the comment docs.

@ghost ghost assigned JustinBeckwith Aug 23, 2018
@renovate renovate bot force-pushed the renovate/google-cloud-common-0.x branch 2 times, most recently from 094a698 to 1035d76 Compare August 28, 2018 15:02
@renovate renovate bot force-pushed the renovate/google-cloud-common-0.x branch from 1035d76 to d165fc9 Compare August 28, 2018 16:38
Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait a second. How do the tests pass? Doesn't this constructor call need a requestModule in the config?

@JustinBeckwith
Copy link
Contributor

Yeah, so funny quirk about our unit tests. They use proxyquire to override the request method in most places, so the complete lack of a request client wouldn't actually break them. I would guess that the system tests fail :)

@fhinkel
Copy link
Contributor

fhinkel commented Aug 30, 2018

But how does it even compile? And how is fakeRequest passed into Service?

@JustinBeckwith
Copy link
Contributor

Closing in favor of #91

@renovate
Copy link
Contributor Author

renovate bot commented Sep 4, 2018

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will now ignore this update (^0.23.0). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the ignoreDeps array of your renovate config.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

@renovate renovate bot deleted the renovate/google-cloud-common-0.x branch September 4, 2018 04:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants