-
Notifications
You must be signed in to change notification settings - Fork 10
fix(deps): update dependency @google-cloud/common to ^0.23.0 #89
Conversation
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 241 241
=====================================
Hits 241 241Continue to review full report at Codecov.
|
094a698 to
1035d76
Compare
1035d76 to
d165fc9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait a second. How do the tests pass? Doesn't this constructor call need a requestModule in the config?
|
Yeah, so funny quirk about our unit tests. They use proxyquire to override the |
|
But how does it even compile? And how is |
|
Closing in favor of #91 |
Renovate Ignore NotificationAs this PR has been closed unmerged, Renovate will now ignore this update (^0.23.0). You will still receive a PR once a newer version is released, so if you wish to permanently ignore this dependency, please add it to the If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened. |
This Pull Request updates dependency
@google-cloud/common(source) from^0.22.0to^0.23.0Note: This PR was created on a configured schedule ("after 9am and before 3pm") and will not receive updates outside those times.
Details
Release Notes
v0.23.0Compare Source
Fixes
Features
Keepin the lights on
This PR has been generated by Renovate Bot.